Re: [Xen-devel] [PATCH] arch: arm: vgic-v3: fix GICD_ISACTIVER range

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 21 Nov 2019, Julien Grall wrote:
> > > As I said in a different sub-thread, I would reluctanly be ok to see
> > > returning
> > > 0 as long as we have add a warning for *every* access. Long-term, the
> > > current
> > > vGIC should really get killed.

After speaking with Julien and reading more about the registers in
question and the Linux changes in 5.4, I changed my mind and agree with
the warning.

Peng, would you be willing to submit a new update of the patch, adding a
warning also? You can reuse the words used in the warning from
vgic_v2_distr_mmio_write, something like:

  printk(XENLOG_G_ERR "%pv: vGICD: unhandled read from ISACTIVER%d\n",
         v, gicd_reg - GICD_ISACTIVER);


Juergen, this is an easy-to-understand typo fix, plus a new warning. It
is important to be able to run Linux 5.4 (see
https://marc.info/?l=xen-devel&m=157372234429588). I think it should go
in 4.13.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel