Re: [Xen-devel] [XEN PATCH for-4.13 v4 6/7] libxl: Introduce libxl__ev_immediate

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("[XEN PATCH for-4.13 v4 6/7] libxl: Introduce 
libxl__ev_immediate"):
> This new ev allows to arrange a non-reentrant callback to be called.
> This happen immediately after the current event is processed and after
> other ev_immediates that would have already been registered.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

However:

> +    while (!LIBXL_STAILQ_EMPTY(&egc->ev_immediates)) {
> +        ei = LIBXL_STAILQ_FIRST(&egc->ev_immediates);
> +        LIBXL_STAILQ_REMOVE_HEAD(&egc->ev_immediates, entry);

I think maybe you were unaware that LIBXL_STAILQ_FIRST may be used on
an empty list and will return NULL.  This makes no difference (the
compiler will get rid of the duplication, surely) but might make the
code fractionally shorter.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel