[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC v5 026/126] python: add commit-per-subsystem.py





On Friday, October 11, 2019, Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx> wrote:
Add script to automatically commit tree-wide changes per-subsystem.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx>
---

Great idea!

Can you just add a comment somewhere close to the top of the file on script usage? Or "--help" option? If you would like to be the script maintainer, please change the MAINTAINERS too.

Reviewed-by: Aleksandar Markovic <amarkovic@xxxxxxxxxxxx>
 

CC: Gerd Hoffmann <kraxel@xxxxxxxxxx>
CC: "Gonglei (Arei)" <arei.gonglei@xxxxxxxxxx>
CC: Eduardo Habkost <ehabkost@xxxxxxxxxx>
CC: Igor Mammedov <imammedo@xxxxxxxxxx>
CC: Laurent Vivier <lvivier@xxxxxxxxxx>
CC: Amit Shah <amit@xxxxxxxxxx>
CC: Kevin Wolf <kwolf@xxxxxxxxxx>
CC: Max Reitz <mreitz@xxxxxxxxxx>
CC: John Snow <jsnow@xxxxxxxxxx>
CC: Ari Sundholm <ari@xxxxxxxxxx>
CC: Pavel Dovgalyuk <pavel.dovgaluk@xxxxxxxxx>
CC: Paolo Bonzini <pbonzini@xxxxxxxxxx>
CC: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
CC: Fam Zheng <fam@xxxxxxxxxx>
CC: Stefan Weil <sw@xxxxxxxxxxx>
CC: Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx>
CC: Peter Lieven <pl@xxxxxxx>
CC: Eric Blake <eblake@xxxxxxxxxx>
CC: "Denis V. Lunev" <den@xxxxxxxxxx>
CC: Markus Armbruster <armbru@xxxxxxxxxx>
CC: Alberto Garcia <berto@xxxxxxxxxx>
CC: Jason Dillaman <dillaman@xxxxxxxxxx>
CC: Wen Congyang <wencongyang2@xxxxxxxxxx>
CC: Xie Changlong <xiechanglong.d@xxxxxxxxx>
CC: Liu Yuan <namei.unix@xxxxxxxxx>
CC: "Richard W.M. Jones" <rjones@xxxxxxxxxx>
CC: Jeff Cody <codyprime@xxxxxxxxx>
CC: "Marc-André Lureau" <marcandre.lureau@xxxxxxxxxx>
CC: "Daniel P. Berrangé" <berrange@xxxxxxxxxx>
CC: Richard Henderson <rth@xxxxxxxxxxx>
CC: Greg Kurz <groug@xxxxxxxx>
CC: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
CC: Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>
CC: Beniamino Galvani <b.galvani@xxxxxxxxx>
CC: Peter Maydell <peter.maydell@xxxxxxxxxx>
CC: "Cédric Le Goater" <clg@xxxxxxxx>
CC: Andrew Jeffery <andrew@xxxxxxxx>
CC: Joel Stanley <joel@xxxxxxxxx>
CC: Andrew Baumann <Andrew.Baumann@xxxxxxxxxxxxx>
CC: "Philippe Mathieu-Daudé" <philmd@xxxxxxxxxx>
CC: Antony Pavlov <antonynpavlov@xxxxxxxxx>
CC: Jean-Christophe Dubois <jcd@xxxxxxxxxxxxxxx>
CC: Peter Chubb <peter.chubb@xxxxxxxxxxxx>
CC: Subbaraya Sundeep <sundeep.lkml@xxxxxxxxx>
CC: Eric Auger <eric.auger@xxxxxxxxxx>
CC: Alistair Francis <alistair@xxxxxxxxxxxxx>
CC: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Anthony Perard <anthony.perard@xxxxxxxxxx>
CC: Paul Durrant <paul@xxxxxxx>
CC: Paul Burton <pburton@xxxxxxxxxxxx>
CC: Aleksandar Rikalo <arikalo@xxxxxxxxxxxx>
CC: Chris Wulff <crwulff@xxxxxxxxx>
CC: Marek Vasut <marex@xxxxxxx>
CC: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
CC: Cornelia Huck <cohuck@xxxxxxxxxx>
CC: Halil Pasic <pasic@xxxxxxxxxxxxx>
CC: Christian Borntraeger <borntraeger@xxxxxxxxxx>
CC: "Hervé Poussineau" <hpoussin@xxxxxxxxxxx>
CC: Xiao Guangrong <xiaoguangrong.eric@xxxxxxxxx>
CC: Aurelien Jarno <aurelien@xxxxxxxxxxx>
CC: Aleksandar Markovic <amarkovic@xxxxxxxxxxxx>
CC: Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>
CC: Jason Wang <jasowang@xxxxxxxxxx>
CC: Laszlo Ersek <lersek@xxxxxxxxxx>
CC: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
CC: Palmer Dabbelt <palmer@xxxxxxxxxx>
CC: Sagar Karandikar <sagark@xxxxxxxxxxxxxxxxx>
CC: Bastian Koppelmann <kbastian@xxxxxxxxxxxxxxxxxxxxx>
CC: David Hildenbrand <david@xxxxxxxxxx>
CC: Thomas Huth <thuth@xxxxxxxxxx>
CC: Eric Farman <farman@xxxxxxxxxxxxx>
CC: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>
CC: Hannes Reinecke <hare@xxxxxxxx>
CC: Michael Walle <michael@xxxxxxxx>
CC: Artyom Tarasenko <atar4qemu@xxxxxxxxx>
CC: Stefan Berger <stefanb@xxxxxxxxxxxxx>
CC: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
CC: Alex Williamson <alex.williamson@xxxxxxxxxx>
CC: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
CC: Pierre Morel <pmorel@xxxxxxxxxxxxx>
CC: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CC: Hailiang Zhang <zhang.zhanghailiang@xxxxxxxxxx>
CC: Juan Quintela <quintela@xxxxxxxxxx>
CC: "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx>
CC: Luigi Rizzo <rizzo@xxxxxxxxxxxx>
CC: Giuseppe Lettieri <g.lettieri@xxxxxxxxxxxx>
CC: Vincenzo Maffione <v.maffione@xxxxxxxxx>
CC: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
CC: Anthony Green <green@xxxxxxxxxxxxxx>
CC: Stafford Horne <shorne@xxxxxxxxx>
CC: Guan Xuetao <gxt@xxxxxxxxxxxxxxx>
CC: Max Filippov <jcmvbkbc@xxxxxxxxx>
CC: qemu-block@xxxxxxxxxx
CC: integration@xxxxxxxxxxx
CC: sheepdog@xxxxxxxxxxxxxx
CC: qemu-arm@xxxxxxxxxx
CC: xen-devel@xxxxxxxxxxxxxxxxxxxx
CC: qemu-ppc@xxxxxxxxxx
CC: qemu-s390x@xxxxxxxxxx
CC: qemu-riscv@xxxxxxxxxx

 python/commit-per-subsystem.py | 204 +++++++++++++++++++++++++++++++++
 1 file changed, 204 insertions(+)
 create mode 100755 python/commit-per-subsystem.py

diff --git a/python/commit-per-subsystem.py b/python/commit-per-subsystem.py
new file mode 100755
index 0000000000..2ccf84cb15
--- /dev/null
+++ b/python/commit-per-subsystem.py
@@ -0,0 +1,204 @@
+#!/usr/bin/env python3
+#
+# Copyright (c) 2019 Virtuozzo International GmbH
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+import subprocess
+import sys
+import os
+import glob
+
+
+def git_add(pattern):
+    subprocess.run(['git', 'add', pattern])
+
+
+def git_commit(msg):
+    subprocess.run(['git', 'commit', '-m', msg], capture_output=True)
+
+
+def git_changed_files():
+    ret = subprocess.check_output(['git', 'diff', '--name-only'], encoding='utf-8').split('\n')
+    if ret[-1] == '':
+        del ret[-1]
+    return ret
+
+
+maintainers = sys.argv[1]
+message = sys.argv[2].strip()
+
+subsystem = None
+
+remap = {
+    'Block layer core': 'block',
+    'Block Jobs': 'block',
+    'Dirty Bitmaps': 'block',
+    'Block QAPI, monitor, command line': 'block',
+    'Block I/O path': 'block',
+    'Throttling infrastructure': 'block',
+    'Architecture support': 's390x',
+    'Guest CPU Cores (KVM)': 'kvm',
+    'Guest CPU Cores (Xen)': 'xen',
+    'Guest CPU cores (TCG)': 'tcg',
+    'Network Block Device (NBD)': 'nbd',
+    'Parallel NOR Flash devices': 'pflash',
+    'Firmware configuration (fw_cfg)': 'fw_cfg',
+    'Block SCSI subsystem': 'scsi',
+    'Network device backends': 'net',
+    'Netmap network backend': 'net',
+    'Host Memory Backends': 'hostmem',
+    'Cryptodev Backends': 'cryptodev',
+    'QEMU Guest Agent': 'qga',
+    'COLO Framework': 'colo',
+    'Command line option argument parsing': 'cmdline',
+    'Character device backends': 'chardev'
+}
+
+
+class Maintainers:
+    def add(self, subsystem, path, mapper, mapper_name, glob_count=1):
+        if subsystem in remap:
+            subsystem = remap[subsystem]
+        if subsystem not in self.subsystems:
+            self.subsystems.append(subsystem)
+
+        if path[-1] == '/':
+            path = path[:-1]
+
+        if path in mapper:
+            if mapper[path][1] == glob_count:
+                print('Warning: "{}" both in "{}" and "{}" in {} mapper with '
+                      'same glob-count={}. {} ignored for this path.'.format(
+                        path, mapper[path][0], subsystem, mapper_name, glob_count,
+                          subsystem))
+                return
+            if mapper[path][1] < glob_count:
+                # silently ignore worse match
+                return
+
+        mapper[path] = (subsystem, glob_count)
+
+    def __init__(self, file_name):
+        self.map_file = {}
+        self.map_glob_file = {}
+        self.map_dir = {}
+        self.map_glob_dir = {}
+        self.map_unmaintained_dir = {
+            'python': ('python', 1),
+            'hw/misc': ('misc', 1)
+        }
+        self.subsystems = ['python', 'misc']
+        subsystem = None
+
+        with open(file_name) as f:
+            mode2 = False
+            prevline = ''
+            for line in f:
+                line = line.rstrip()
+                if not line:
+                    continue
+                if len(line) >= 2 and line[1] == ':':
+                    if line[0] == 'F':
+                        fname = line[3:]
+                        if fname in ['*', '*/']:
+                            continue
+                        if os.path.isfile(fname):
+                            self.add(subsystem, fname, self.map_file, 'file')
+                        elif os.path.isdir(fname):
+                            self.add(subsystem, fname, self.map_dir, 'dir')
+                        else:
+                            paths = glob.glob(fname)
+                            if not paths:
+                                print('Warning: nothing corresponds to "{}"'.format(fname))
+                                continue
+
+                            n = len(paths)
+                            for f in paths:
+                                if os.path.isfile(f):
+                                    self.add(subsystem, f, self.map_glob_file, 'glob-file', n)
+                                else:
+                                    assert os.path.isdir(f)
+                                    self.add(subsystem, f, self.map_glob_dir, 'glob-dir', n)
+                elif line[:3] == '---':
+                    subsystem = prevline
+                    if subsystem == 'Devices':
+                        mode2 = True
+                elif mode2:
+                    subsystem = line
+                prevline = line
+
+    def find_in_map_dir(self, file_name, mapper):
+        while file_name != '' and file_name not in mapper:
+            file_name = os.path.dirname(file_name)
+
+        return None if file_name == '' else mapper[file_name][0]
+
+    def find_in_map_file(self, file_name, mapper):
+        if file_name in mapper:
+            return mapper[file_name][0]
+
+    def find_subsystem(self, file_name):
+        s = self.find_in_map_file(file_name, self.map_file)
+        if s is not None:
+            return s
+
+        s = self.find_in_map_file(file_name, self.map_glob_file)
+        if s is not None:
+            return s
+
+        s = self.find_in_map_dir(file_name, self.map_dir)
+        if s is not None:
+            return s
+
+        s = self.find_in_map_dir(file_name, self.map_glob_dir)
+        if s is not None:
+            return s
+
+        s = self.find_in_map_dir(file_name, self.map_unmaintained_dir)
+        if s is not None:
+            return s
+
+        self.subsystems.append(file_name)
+        return file_name
+
+
+def commit(subsystem):
+    msg = subsystem
+    if msg in remap:
+        msg = remap[msg]
+    msg += ': ' + message
+    git_commit(msg)
+
+mnt = Maintainers(maintainers)
+res = {}
+for f in git_changed_files():
+    s = mnt.find_subsystem(f)
+    if s in res:
+        res[s].append(f)
+    else:
+        res[s] = [f]
+
+for s in mnt.subsystems:
+    if s in res:
+        print(s)
+        for f in res[s]:
+            print('  ', f)
+
+for s in mnt.subsystems:
+    if s in res:
+        for f in res[s]:
+            git_add(f)
+        commit(s)
--
2.21.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.