Re: [Xen-devel] [PULL v2 0/3] Trivial branch patches

[no-reply@xxxxxxxxxxx]

Patchew URL: https://patchew.org/QEMU/20191105175010.2591-1-laurent@xxxxxxxxx/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Xen-devel] [PULL v2 0/3] Trivial branch patches
Type: series
Message-id: 20191105175010.2591-1-laurent@xxxxxxxxx

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
49a55f7 global: Squash 'the the'
c0b5513 hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses
eb43395 hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers

=== OUTPUT BEGIN ===
1/3 Checking commit eb43395bf8f1 (hw/misc/grlib_ahb_apb_pnp: Avoid crash when 
writing to PnP registers)
2/3 Checking commit c0b5513f971a (hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses)
3/3 Checking commit 49a55f7feb19 (global: Squash 'the the')
ERROR: do not use C99 // comments
#26: FILE: disas/libvixl/vixl/invalset.h:105:
+  // Note that this does not mean the backing storage is empty: it can still

total: 1 errors, 0 warnings, 56 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191105175010.2591-1-laurent@xxxxxxxxx/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxx
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel