Re: [Xen-devel] [PATCH v2 1/8] stubdom/vtpm: include stdio.h for declaration of printf

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Samuel Thibault, le dim. 13 oct. 2019 18:20:39 +0200, a ecrit:
> Olaf Hering, le mer. 02 oct. 2019 19:05:36 +0200, a ecrit:
> > The function read_vtpmblk uses printf(3), but stdio.h is not included
> > in this file. This results in a warning from gcc-7:
> > 
> > vtpmblk.c: In function 'read_vtpmblk':
> > vtpmblk.c:322:7: warning: implicit declaration of function 'printf' 
> > [-Wimplicit-function-declaration]
> >        printf("Expected: ");
> > vtpmblk.c:322:7: warning: incompatible implicit declaration of built-in 
> > function 'printf'
> > vtpmblk.c:322:7: note: include '<stdio.h>' or provide a declaration of 
> > 'printf'
> > 
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > cked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

Note that you miss an 'A' at the beginning of the line there.



> Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> > ---
> >  stubdom/vtpm/vtpmblk.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/stubdom/vtpm/vtpmblk.c b/stubdom/vtpm/vtpmblk.c
> > index fe529ab5ac..681f0c01b6 100644
> > --- a/stubdom/vtpm/vtpmblk.c
> > +++ b/stubdom/vtpm/vtpmblk.c
> > @@ -20,6 +20,7 @@
> >  #include <unistd.h>
> >  #include <errno.h>
> >  #include <fcntl.h>
> > +#include <stdio.h>
> >  
> >  /*Encryption key and block sizes */
> >  #define BLKSZ 16
> > 
> 
> -- 
> Samuel
> <P> moo
> <N> moo ?
> <D> P: keski t'arrive? :))
> <P> moooo
> <N> moooooo ?
> <P> rien le net marche je suis content :)
>  -+- #ens-mim - accro du net -+-

-- 
Samuel
>Ever heard of .cshrc?
That's a city in Bosnia.  Right?
(Discussion in comp.os.linux.misc on the intuitiveness of commands.)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel