[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] efi/boot: fix set_color function


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
  • Date: Fri, 4 Oct 2019 12:25:17 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@xxxxxxxxxx; spf=Pass smtp.mailfrom=igor.druzhinin@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 04 Oct 2019 11:25:29 +0000
  • Ironport-sdr: 43yXnoQ/pM6dMnodVzX2VDIOrxbAklOCKj6gyexv2N1J6XXBsFWdZVeyiRNO46YSUp2mqByVxA +yLsRvm3h8I6qMkStJ0SSrqKb8xXslnXwZ1Y5PuPdXe6BF3Vq6mNBpqtvzTE+JK7bepfTPDebY w2tSsoqxB5ye5F2Cixq8aPuajVkH2rXqfiImUO1ns0/ZfYFMCOh8V/M5hxsXOHq7MFMa5ndx6u IMOAHqRk2IlgqKRtOWS5b4bmGICGKCbNMfoXxCJwsLFdhtR5i2iuSy9rKGiBbmXxzniiQ72nqo rh8=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04/10/2019 12:14, Jan Beulich wrote:
> On 04.10.2019 12:54, Igor Druzhinin wrote:
>> On 04/10/2019 11:34, Jan Beulich wrote:
>>> On 03.10.2019 15:49, Igor Druzhinin wrote:
>>>> - 0 is a possible and allowed value for a color mask accroding to
>>>>   UEFI Spec 2.6 (11.9) especially for reserved mask
>>>
>>> Hmm, looking at 2.8 (where it's section 12.9, which in turn is why
>>> section titles would be more helpful in such references) I can't
>>> see the case being mentioned explicitly. I can accept that
>>> ReservedMask might be zero, but then I'd prefer to handle that
>>> case in the caller, rather than allowing zero also for the three
>>> colors.
>>
>> "If a bit is set in RedMask, GreenMask, or BlueMask then those bits of
>> the pixel represent the corresponding color." - "If a bit is set..."
>> implies it might not be set.
> 
> This talks about the function of individual bits. There's nothing said
> about not bit at all being set for a particular color.
> 

I know certainly that it's not only me who reads this sentence the same
way - firmware developers as well. But if you insist I will restrict
this change to reserved mask only.

Igor

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.