[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v1 1/6] docs: add feature document for Xen hypervisor sysfs-like support



On 30.09.19 12:07, Ian Jackson wrote:
Jürgen Groß writes ("Re: [PATCH v1 1/6] docs: add feature document for Xen 
hypervisor sysfs-like support"):
On 30.09.19 10:57, Jan Beulich wrote:
On 30.09.2019 10:17, Jürgen Groß wrote:
.config can contain user supplied strings. While not making much sense
to have unprintable characters in there I don't see how to prevent them.

Does / can't kconfig reject them?

Right now it doesn't.

I tested that by manually modifying my .config and then doing a make.
The (wrong) .config was accepted and the hypervisor built with it.

Urgh.

I think that either

(A) this needs to be prevented somehow, or

Difficult, as we inherit kconfig from the Linux kernel.

(B) your userland tools, at the very least, need souping up so that
they (i) by default do not risk spamming the user's terminal with
binary gibberish which someone stored in xenhypfs (ii) can be used to
reliably extract any binary objects which have been stored.

I think (B)(i) necessarily involves some kind of quoting scheme :-/.
(B)(ii) means the quoting needs to be turn-off-able.

Yes, this seems to be a sensible thing to do.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.