Re: [Xen-devel] [xen-unstable test] 141990: regressions - FAIL

[Jürgen Groß <jgross@xxxxxxxx>]

On 30.09.19 06:23, osstest service owner wrote:
> flight 141990 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/141990/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>   test-amd64-amd64-xl-qemut-debianhvm-amd64  7 xen-boot    fail REGR. vs. 141822
>   test-amd64-amd64-libvirt     12 guest-start              fail REGR. vs. 141822
>   test-amd64-i386-libvirt-xsm  12 guest-start              fail REGR. vs. 141822
>   test-amd64-amd64-libvirt-pair 22 guest-migrate/src_host/dst_host fail REGR. 
> vs. 141822
>   test-amd64-i386-libvirt      12 guest-start              fail REGR. vs. 141822
>   test-amd64-amd64-migrupgrade 22 guest-migrate/src_host/dst_host fail REGR. 
> vs. 141822
>   test-amd64-i386-libvirt-pair 22 guest-migrate/src_host/dst_host fail REGR. 
> vs. 141822
>   test-amd64-i386-migrupgrade 22 guest-migrate/src_host/dst_host fail REGR. vs. 
> 141822
>   test-arm64-arm64-examine    11 examine-serial/bootloader fail REGR. vs. 141822
>   test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install 
> fail REGR. vs. 141822
>   test-arm64-arm64-libvirt-xsm 12 guest-start              fail REGR. vs. 141822
>   test-amd64-amd64-libvirt-vhd 10 debian-di-install        fail REGR. vs. 141822
>   test-armhf-armhf-libvirt     12 guest-start              fail REGR. vs. 141822
>   test-armhf-armhf-libvirt-raw 10 debian-di-install        fail REGR. vs. 141822
Several of the failures seem to be related to commit babde47a3feda6dd4
("introduce a 'passthrough' configuration option to xl.cfg").

I think the assert() in lixl_create.c (line 589) should just be dropped?

        assert(info->passthrough != LIBXL_PASSTHROUGH_ENABLED);
        LOG(DETAIL, "passthrough: %s",
            libxl_passthrough_to_string(info->passthrough));

        if (info->passthrough != LIBXL_PASSTHROUGH_DISABLED)
            create.flags |= XEN_DOMCTL_CDF_iommu;

        if (info->passthrough == LIBXL_PASSTHROUGH_SYNC_PT)
            create.iommu_opts |= XEN_DOMCTL_IOMMU_no_sharept;

Or the if () statements after that are just plain wrong?


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel