Re: [Xen-devel] [PATCH v3 14/47] xen/sched: make null scheduler vcpu agnostic.

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Sat, 2019-09-14 at 10:52 +0200, Juergen Gross wrote:
> Switch null scheduler completely from vcpu to sched_unit usage.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>

With, if possible, all the occurrences of 'item' in comments actually
replaced with 'unit'.

Like, for instance, these...

> diff --git a/xen/common/sched_null.c b/xen/common/sched_null.c
> index 63ee1f5439..c3666c9f56 100644
> --- a/xen/common/sched_null.c
> +++ b/xen/common/sched_null.c
> @@ -18,10 +18,10 @@
>  
>  /*
>   * The 'null' scheduler always choose to run, on each pCPU, either
> nothing
> - * (i.e., the pCPU stays idle) or always the same vCPU.
> + * (i.e., the pCPU stays idle) or always the same Item.
>   *
>   * It is aimed at supporting static scenarios, where there always
> are
> - * less vCPUs than pCPUs (and the vCPUs don't need to move among
> pCPUs
> + * less Items than pCPUs (and the Items don't need to move among
> pCPUs
>   * for any reason) with the least possible overhead.
>   *
>   * Typical usecase are embedded applications, but also HPC,
> especially
> 
...

> @@ -77,25 +77,25 @@
>  struct null_private {
>      spinlock_t lock;        /* scheduler lock; nests inside
> cpupool_lock */
>      struct list_head ndom;  /* Domains of this
> scheduler                 */
> -    struct list_head waitq; /* vCPUs not assigned to any
> pCPU            */
> +    struct list_head waitq; /* Items not assigned to any
> pCPU            */
>      spinlock_t waitq_lock;  /* serializes waitq; nests inside runq
> locks */
> -    cpumask_t cpus_free;    /* CPUs without a vCPU associated to
> them    */
> +    cpumask_t cpus_free;    /* CPUs without a Item associated to
> them    */
>  };
>
Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel