[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH STABLE 4.9] x86, mm, gup: prevent get_page() race with munmap in paravirt guest
 
- To: Ben Hutchings <ben@xxxxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
 
- From: Vlastimil Babka <vbabka@xxxxxxx>
 
- Date: Mon, 23 Sep 2019 10:48:04 +0200
 
- Cc: Juergen Gross <jgross@xxxxxxxx>, Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, "Kirill A . Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>
 
- Delivery-date: Mon, 23 Sep 2019 08:48:15 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On 9/19/19 8:26 PM, Ben Hutchings wrote:
 
On Mon, 2019-08-19 at 18:58 +0100, Vlastimil Babka wrote:
[...]
 
Hi, I'm sending this stable-only patch for consideration because it's probably
unrealistic to backport the 4.13 switch to generic GUP. I can look at 4.4 and
3.16 if accepted. The RCU page table freeing could be also considered.
 
 
I would be interested in backports for 3.16 and 4.4.
 
Note the patch also includes page refcount protection. I found out that
8fde12ca79af ("mm: prevent get_user_pages() from overflowing page refcount")
backport to 4.9 missed the arch-specific gup implementations:
https://lore.kernel.org/lkml/6650323f-dbc9-f069-000b-f6b0f941a065@xxxxxxx/
 
[...]
I suppose that still needs to be addressed for 4.9, right?
 
 
Yeah, I'll take a look, thanks for reminding.
 
Ben.
 
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel 
 
    
     |