Re: [Xen-devel] [PATCH] libxlu: Handle += in config files

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Ian Jackson writes ("Re: [PATCH] libxlu: Handle += in config files"):
> Anthony PERARD writes ("Re: [PATCH] libxlu: Handle += in config files"):
> > I wonder if instead of doing += on all strings, we should instead have
> > `xl' whitelist the few options where += would make sense. (and at that
> > point, it would be easy to add a ' ' where is make sense, like
> > "cmdline"s. But then, how to tell users that it can't do "name+='-new'"?
> > because xlu would just print a warning, and xl would keep going with
> > name="".  Try "xl create memory+=42" ;-).
> 
> Do we really need to gold-plate it like this ?  If someone tries to
> append to a string when it doesn't make sense the software will still
> do what they ought to have expected.  And it doesn't seem like a
> likely kind of error.
> 
> As for the original patch,
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I reread the thread and I think there were no blocking objections.
So I have pushed it.

Thanks,
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel