Re: [Xen-devel] [PATCH v2 03/11] ioreq: switch selection and forwarding to use ioservid_t

[Jan Beulich <jbeulich@xxxxxxxx>]

On 10.09.2019 14:31, Paul Durrant wrote:
>> -----Original Message-----
>> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
>> Sent: 03 September 2019 17:14
>> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
>> Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>; 
>> Andrew Cooper
>> <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; George Dunlap 
>> <George.Dunlap@xxxxxxxxxx>; Ian
>> Jackson <Ian.Jackson@xxxxxxxxxx>; Julien Grall <julien.grall@xxxxxxx>; 
>> Konrad Rzeszutek Wilk
>> <konrad.wilk@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Tim 
>> (Xen.org) <tim@xxxxxxx>;
>> Paul Durrant <Paul.Durrant@xxxxxxxxxx>
>> Subject: [PATCH v2 03/11] ioreq: switch selection and forwarding to use 
>> ioservid_t
>>
>> hvm_select_ioreq_server and hvm_send_ioreq where both using
>> hvm_ioreq_server directly, switch to use ioservid_t in order to select
>> and forward ioreqs.
>>
>> This is a preparatory change, since future patches will use the ioreq
>> server id in order to differentiate between internal and external
>> ioreq servers.
>>
>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> ... with one suggestion.
> 
> [snip]
>> diff --git a/xen/include/public/hvm/dm_op.h b/xen/include/public/hvm/dm_op.h
>> index d3b554d019..8725cc20d3 100644
>> --- a/xen/include/public/hvm/dm_op.h
>> +++ b/xen/include/public/hvm/dm_op.h
>> @@ -54,6 +54,7 @@
>>   */
>>
>>  typedef uint16_t ioservid_t;
>> +#define XEN_INVALID_IOSERVID 0xffff
>>
> 
> Perhaps use (ioservid_t)~0 rather than hardcoding?

And then (suitably parenthesized) applicable parts
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel