Re: [Xen-devel] [PATCH v3 10/47] xen/sched: add scheduler helpers hiding vcpu

[Jan Beulich <jbeulich@xxxxxxxx>]

On 14.09.2019 10:52, Juergen Gross wrote:
> Add the following helpers using a sched_unit as input instead of a
> vcpu:
> 
> - is_idle_unit() similar to is_idle_vcpu()
> - is_unit_online() similar to is_vcpu_online() (returns true when any
>   of its vcpus is online)
> - unit_runnable() like vcpu_runnable() (returns true if any of its
>   vcpus is runnable)
> - sched_set_res() to set the current scheduling resource of a unit
> - sched_unit_cpu() to get the current processor of a unit (returns
>   the master_cpu of the scheduling resource of a unit)

And hence perhaps better sched_unit_master() or sched_unit_master_cpu()?

> - sched_{set|clear}_pause_flags[_atomic]() to modify pause_flags of the
>   associated vcpu(s) (modifies the pause_flags of all vcpus of the
>   unit)

I continue to think that it would have been better to have all of
these have their loops right from the beginning. But it'll be the
scheduler maintainers anyway to ack (or not) the patch in its
current shape.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel