Re: [Xen-devel] [PATCH] xen/arm: platform: additional Raspberry Pi compatible string

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 9/13/19 8:11 PM, Stewart Hildebrand wrote:
> Upstream Linux kernel will use "brcm,bcm2711" as the compatible string
> for Raspberry Pi 4 [1]. Add this string to our platform compatible list
> for compatibility with the upstream kernel.
This raises a few questions:
   1) Why such discrepancies in naming?
   2) Is the patch [1] merged? If so, which version?
   3) Both upstream and non-upstream seem to have the compatible 
"raspberrypi,4-model-b", so would it make sense to check that instead?
> [1] https://patchwork.kernel.org/patch/11092621/
>
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxxxxxxxxxx>
> ---
>   xen/arch/arm/platforms/brcm-raspberry-pi.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c 
> b/xen/arch/arm/platforms/brcm-raspberry-pi.c
> index e22d2b3184..a95a3db83f 100644
> --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c
> +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c
> @@ -21,6 +21,7 @@
>   
>   static const char *const brcm_bcm2838_dt_compat[] __initconst =
>   {
> +    "brcm,bcm2711",
If a new compatible is added, then you likely need to rename the 
different structure within this file.
>       "brcm,bcm2838",
>       NULL
>   };
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel