Re: [Xen-devel] [PATCH v4 2/2] sysctl: report shadow paging capability

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v4 2/2] sysctl: report shadow paging 
capability"):
> Report whether shadow paging is supported by the hypervisor, since it
> can be disabled at build time.
...
> NB: I'm not sure the added check in
> libxl__domain_create_info_setdefault is that useful, or if it could be
> better placed somewhere else.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> +        if (!info.cap_hap && !info.cap_shadow) {
> +            LOG(ERROR, "neither hap nor shadow paging available");
> +            return ERROR_INVAL;
> +        }
> +
>          libxl_defbool_setdefault(&c_info->hap, info.cap_hap);

I would have written

  if (cap_hap) setdefault(info->hap, true);
  else if (cap_shadow) setdefault(info->hap, false);
  else bomb_out();

but the result is equivalent.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel