[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()


  • To: Julien Grall <julien.grall@xxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Wed, 11 Sep 2019 17:33:41 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NigbpUrL5HMP4/yfs0p43jMb7ssjY5WhmB0o2fOLwXA=; b=R1CoWzyFLGQLeKCfnPpP5MYmlAHQOslSA2lsvVuGVQb6uc+nDgex/6Qm2R0hO3Cp57rj5VNpORY3RTw49b2aSL1VHTGJPp59o0TXReXCcvV9Mst13x+wf3OXsIk9UqPiE9NMB1PXIf3kHlX5KXfhiOKiV54Fb7pEqmuFugrYh35Thni8Nwa/+WBnhlMllDhb89ARwp5YM3P4e361WUSCLWNuKLyIAhgsIsTx6GqF+Kj7IHditgERu/smJ8BTDbicDwJ52QPkfk3XzE4kDu13fxRgU0Cdi2e/HWQXWDce4fxU9ftXqWEBRieA0+RnqeVDPI1DdxyslnqpaI3Aw/PBlg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BqvDv5uIIe9LgjA8Vm+Pjj9v3SZOQToVp4HlxT1YbJrqwLsCFFUSqB9QgSQ/bynRwHefq7ZWTXF7K+IPO3/Zn7xp3SP5lAT9kGCcIXqNVs8Zy6mzooR8ayqagWKddeYBNKFRRfJKTta0h3WMNusT71cus0pvuXcq2nonoczF/irxodDvLmo+6i+HVQ25Els6yQNl4oD6ULkC0IKlguCT+BxjT0jO5GrxDHi8aqnIEYiU3y8LHvuVoRm+hZAUT+iWJUjkeEPqOZJDCXuiGf+Rw0i7M28BYprxV2vRzr19ZTmnwTz/V9511Ox0XNSQPJC67kB2cClPTY8DwtRr6jp5zA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 11 Sep 2019 17:33:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVaLRki9HO4fjSXUWIq6dkBI8peacmvLAA
  • Thread-topic: [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()

Julien Grall writes:

> One line in process_multiboot_node() is using hard tab rather than soft
> tab. So fix it!
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

So, hunting them one-by-one is the preferred way? I'm asking this
because there are more of them:

% find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
xen/arch/arm/traps.c
xen/arch/arm/acpi/boot.c
xen/arch/arm/arm32/lib/assembler.h
xen/arch/arm/arm64/livepatch.c
xen/arch/arm/arm64/lib/find_next_bit.c
xen/arch/arm/arm64/insn.c
xen/arch/arm/alternative.c
xen/arch/arm/bootfdt.c (apparently, I don't have this patch applied)


> ---
>  xen/arch/arm/bootfdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 258b057f00..623173bc7f 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -264,7 +264,7 @@ static void __init process_multiboot_node(const void 
> *fdt, int node,
>          case 1: kind = BOOTMOD_RAMDISK; break;
>          default: break;
>          }
> -     if ( kind_guess > 1 && has_xsm_magic(start) )
> +        if ( kind_guess > 1 && has_xsm_magic(start) )
>              kind = BOOTMOD_XSM;
>      }


-- 
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.