[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v9] x86/emulate: Send vm_event from emulate
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxxxxxx>
- Date: Wed, 11 Sep 2019 11:44:04 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bbu.bitdefender.biz; dkim=pass header.d=bbu.bitdefender.biz; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XCawvUXLYm4n7+VxidohjIt8U6LQXWi3qNegnjgHZJI=; b=P59dBzAfJwyT00QnCh36PFAOWFtTTZuKw2W3gJDphRVjH0htpyNTgPxM2KAoahaBJinXWub+xIKmQhzb764l9eyVGNR8M0ZRF6f4piF+itUr/eMDaKheNvTWXqifAsjbQuuoyP7WRW5aYy49phWnf3g8JKUlU2waOZ21her6ZiU+8uIjfKf4UV/JBVhojEuFjXmVUlBRHPWvbIIRbZgO796Z4lWsIPjKfiYb5vgUHlaQuGqtIJq/N7aWD3Mok8DA+snpwBpYZJtwI5cQj//lMFzit+W1Dgc3r955o++eykl+tWeaxm/MKXEnw6+jHPyMVKjQ0MkPYAUU5FLUCuKDjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k2rY3xNeapVx1Y5GFWX/6LiiqLamNIqqngBqYqIRe1HCIx+U0nqqxKIUeIySuDSUSF5LuYlTGKBZEYLZ7ha6HuQ9PA/yFynepH5e2AFFywI4H3O7Xjz0vAbEGQ7DxeBHo5Uj1fs/tqQGD7LVGQBGwq3Dfz/oOtaMW7Jd7Ug2QC7nASCn631nXW9Rvzo6y7FCvXejbuu12masoV7bizglJB7YPVR++/CsBVB+P41rbYYoxUYnTktT3YxKeEvYR9aIGD7p/GYjKjGGxLSXVouydiDxC+V1rUjVzkVkS42D68GbThbUYPrfDFWCKCDCoOjzYOyv0JJztEGC/YjoBCP8Og==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=rcojocaru@xxxxxxxxxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, "tamas@xxxxxxxxxxxxx" <tamas@xxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "paul.durrant@xxxxxxxxxx" <paul.durrant@xxxxxxxxxx>, Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 11 Sep 2019 11:44:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVZyQz09ftstBAgkqLCbI9BLbek6cmQG2AgAALiACAAD4ggP//03EAgAAAmQA=
- Thread-topic: [PATCH v9] x86/emulate: Send vm_event from emulate
On 9/11/19 2:41 PM, Jan Beulich wrote:
> On 11.09.2019 13:21, Razvan Cojocaru wrote:
>> On 9/11/19 1:39 PM, Alexandru Stefan ISAILA wrote:
>>>
>>>
>>> On 11.09.2019 12:57, Jan Beulich wrote:
>>>> On 09.09.2019 17:35, Alexandru Stefan ISAILA wrote:
>>>>> +/*
>>>>> + * Send memory access vm_events based on pfec. Returns true if the event
>>>>> was
>>>>> + * sent and false for p2m_get_mem_access() error, no violation and event
>>>>> send
>>>>> + * error. Assumes the caller will check arch.vm_event->send_event.
>>>>> + *
>>>>> + * NOTE: p2m_get_mem_access() can fail if the entry was not found in the
>>>>> EPT
>>>>> + * (in which case access to it is unrestricted, so no violations can
>>>>> occur).
>>>>> + * In this cases it is fine to continue the emulation.
>>>>> + */
>>>>> +bool hvm_monitor_check_ept(unsigned long gla, gfn_t gfn, uint32_t pfec,
>>>>> + uint16_t kind)
>>>>
>>>> Why did you choose to have "ept" in the name and also mention it
>>>> in the commit? Is there anything in here which isn't generic p2m?
>>>
>>> The name was suggested by Razvan Cojocaru. I have no preference in the
>>> name. Maybe Tamas can suggest a good one.
>>
>> I've suggested "ept" in the name because "regular" emulation ignores it,
>> and this function takes it into account, hence the "check_ept" (which I
>> thought would be read together). It's fine to change it to something else.
>
> Then "check_p2m" perhaps?
Sounds good to me.
Thanks,
Razvan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
