[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks
- To: Ian Jackson <Ian.Jackson@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Tue, 10 Sep 2019 08:29:22 +0000
- Accept-language: en-GB, en-US
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=christian.lindig@xxxxxxxxxx; spf=Pass smtp.mailfrom=christian.lindig@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 10 Sep 2019 08:29:44 +0000
- Ironport-sdr: l6fKTzl5ls7/0I1fgSN2+uBI9OiVbrl9MnogEOcc3MuldorIUnKzvQ/cvIRErSDtL4wpBvo4X6 MCNizUbc1WIqtt3Kc1T7zxtXaS3ItoFebP1dhPCmG4wC5+GPGtMZhiHpH2QjJGRI1/qbIVFeVl TX1SVJ1e9N1R8x1LLP7e3/vB2B8NC65nJrYKML1WgiAqsjZ8TOhnHzoO57xF3BUFQTM5wdZk2G SNUCuiAtA04r9e+qRnGQ5fbclgKFwyfZcyrJPzoRJn3M69qBH2Hx6tezlSkhE6WZr8wzDKgcLY pH8=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVZzHc1/lsKqnUHUmmAY4psG3Nw6ckc8WA
- Thread-topic: [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks
> On 9 Sep 2019, at 18:12, Ian Jackson <ian.jackson@xxxxxxxxxxxxx> wrote:
>
>
> Add build machinery which will check the ABI correspondence.
>
> This will result in a compile time failure whenever constants get
> renumbered/added without a compatible adjustment to the Ocaml ABI.
I understand the desire to automate this but would have kept the original
proposal for these reasons: changes are rare enough, it is obvious how to
extend the scheme, the approach stayed well within the respective languages.
Adding parsers and code generators to the build system will make it more
difficult to improve it, which at least for the OCaml part is very desirable.
However, I’m not going to object to the patch.
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
— Christian
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
