Re: [Xen-devel] [PATCH v3] evtchn: Introduce a per-guest knob to control FIFO ABI

[Jan Beulich <jbeulich@xxxxxxxx>]

On 19.08.2019 14:08, Eslam Elnikety wrote:
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1170,6 +1170,7 @@ long do_event_channel_op(int cmd, 
> XEN_GUEST_HANDLE_PARAM(void) arg)
>  
>      case EVTCHNOP_init_control: {
>          struct evtchn_init_control init_control;
> +
>          if ( copy_from_guest(&init_control, arg, 1) != 0 )
>              return -EFAULT;
>          rc = evtchn_fifo_init_control(&init_control);

Stray (leftover?) change. If intended, it should be a separate
patch dealing with all similar issues within this switch().

Apart from this cosmetic adjustment (which could be done by
the committer if no other need for a v4 arises) I can live with
this change in its current shape now, but I'm hesitant to give
my ack for the reason stated during v1/v2 review.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel