[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/6] remove late (on-demand) construction of IOMMU page tables

On 12.08.2019 17:41, Paul Durrant wrote:
From: Jan Beulich <jbeulich@xxxxxxxx>
Sent: 07 August 2019 11:32

On 30.07.2019 15:44, Paul Durrant wrote:
@@ -625,8 +548,7 @@ static void iommu_dump_p2m_table(unsigned char key)
       ops = iommu_get_ops();
-        if ( is_hardware_domain(d) ||
-             dom_iommu(d)->status < IOMMU_STATUS_initialized )
+        if ( !is_iommu_enabled(d) )

Why do you drop the hwdom check here?

Because is_iommu_enabled() for the h/w domain will always be true if
iommu_enabled is true, so no need for a special case.

But the effect of the extra check was to _skip_ Dom0. If you mean to
change this, then you should say so (and why) in the description.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.