[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] livepatch: always print XENLOG_ERR information (ARM, ELF)
Hi,
On 8/21/19 11:20 AM, Andrew Cooper wrote:
On 21/08/2019 11:04, Pawel Wieczorkiewicz wrote:
diff --git a/xen/common/livepatch_elf.c b/xen/common/livepatch_elf.c
index dd8b47a1fa..18b9684aeb 100644
--- a/xen/common/livepatch_elf.c
+++ b/xen/common/livepatch_elf.c
@@ -55,7 +55,7 @@ static int elf_resolve_sections(struct livepatch_elf *elf,
const void *data)
sec = xzalloc_array(struct livepatch_elf_sec, elf->hdr->e_shnum);
if ( !sec )
{
- dprintk(XENLOG_ERR, LIVEPATCH"%s: Could not allocate memory for section
table!\n",
+ printk(XENLOG_ERR LIVEPATCH"%s: Could not allocate memory for section
table\n",
elf->name);
return -ENOMEM;
}
@@ -81,22 +81,22 @@ static int elf_resolve_sections(struct livepatch_elf *elf,
const void *data)
(sec[i].sec->sh_type != SHT_NOBITS && /* Skip SHT_NOBITS */
(delta > elf->len || (delta + sec[i].sec->sh_size > elf->len)))
)
{
- dprintk(XENLOG_ERR, LIVEPATCH "%s: Section [%u] data %s of
payload!\n",
- elf->name, i,
+ printk(XENLOG_ERR LIVEPATCH "%s: Section [%u] data %s of
payload\n",
+ elf->name, i,
delta < sizeof(Elf_Ehdr) ? "at ELF header" : "is past
end");
@@ -328,7 +328,7 @@ int livepatch_elf_resolve_symbols(struct livepatch_elf *elf)
if ( rc )
{
- dprintk(XENLOG_ERR, LIVEPATCH "%s: Out of bounds symbol section
%#x\n",
+ printk(XENLOG_ERR LIVEPATCH "%s: Out of bounds symbol section
%#x\n",
elf->name, idx);
break;
}
These three hunks have minor indentation/spacing issues. All can be
fixed up on commit.
Acked-by: Julien Grall <julien.grall@xxxxxxx>
Even if this some of the code is under arch/arm, this still need an ack
from Konrad/Ross.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
