[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] tools/oxenstored: port XS_INTRODUCE evtchn rebind function from cxenstored
- To: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Tue, 20 Aug 2019 13:09:51 +0000
- Accept-language: en-GB, en-US
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=christian.lindig@xxxxxxxxxx; spf=Pass smtp.mailfrom=christian.lindig@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, David Scott <dave@xxxxxxxxxx>
- Delivery-date: Tue, 20 Aug 2019 13:09:59 +0000
- Ironport-sdr: CDvCOxymEVbvxWxHZmVmPefH8KmAWBjxE8+MS3ElXq3+C/S8mT3ZmwJ1zDD8NSkTPKc8m41W/U RAYPhebesgC+bDLhp5owiCtDWEloCttXZBnftUQ3vj3yFKPacmrKI4HERZw/KKrUwo5WRUE7Sq t/0PiplMXAorKEcdviQGqhhtuKF+z3l6eS+BQIQnzA0fDy7ZUbbvex70vMMdnJ6FSwTih28hm9 DaLBwfPlNJy5TELV7CUado0TWnzRMMSfiTiUjvZmG/G8NreytL42yZGpEmvc+M1ykdGIumjypm wwQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVVr5MK6au/yYrc0WquZUXd0SG76cDkYSAgAAoOACAABgFAIAACWmAgAAG6gA=
- Thread-topic: [PATCH] tools/oxenstored: port XS_INTRODUCE evtchn rebind function from cxenstored
> On 20 Aug 2019, at 13:45, Igor Druzhinin <igor.druzhinin@xxxxxxxxxx> wrote:
>
> con is passed into that function from xenstored.ml where it's extracted
> from the same hashtable (Connections) so it's actually the exactly same
> object.
This comes down to what semantics you want. It is unfortunate that Connection.t
is not abstract and its equality not well defined. Using != now relies on the
fact that you only compare values stored in the same hash table.
— C
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
