Re: [Xen-devel] [PATCH] x86/p2m: fix non-translated handling of iommu mappings

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Aug 19, 2019 at 06:57:06PM -0700, Roman Shaposhnik wrote:
> On Mon, Jul 22, 2019 at 8:33 AM Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
> >
> > The current usage of need_iommu_pt_sync in p2m for non-translated
> > guests is wrong because it doesn't correctly handle a relaxed PV
> > hardware domain, that has need_sync set to false, but still need
> > entries to be added from calls to {set/clear}_identity_p2m_entry.
> >
> > Adjust the code in guest_physmap_add_page to also check whether the
> > domain has an iommu instead of whether it needs syncing or not in
> > order to take a reference to a page to be mapped.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Cc: Wei Liu <wl@xxxxxxx>
> > Cc: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> 
> Tested-by: Roman Shaposhnik <roman@xxxxxxxxxx>

There's a v2 of the patch, but I guess your TB also applies to it.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel