[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] xen/arm: domain_build: Remove redundant check in make_vpl011_uart_node()
- To: Julien Grall <julien.grall@xxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Fri, 16 Aug 2019 16:28:34 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZsmwJZhtnZbR933P2DLguPI28TYxlsPumvnnFcU4UOk=; b=fygQV/ZVAsZBgbRq195nNFprmaOTd/07Nx4Z5j1Dtz7zhyxGZT3vdhVrC2pcSSmze2KkClb+58Jz7AL+CNUtHpASftgnu/UzPV28VLDUTKoUIvPOHas2VwmivkszLxno4smJJOE1W0Dgo6PR3A6o/XuBmHtytEP47a5r2b55BtY3tTPVZwMYpj5JElcFjmbK55Ro70bGgjTvsqwQImrO6mS20NJZPkmTmiEFTwAmknHNQkL/QMbsidUUqF9CgRrVdzx7HvskWjEQYcRDKv60UrS8Mwvzftju6Yi24nZnAwNuduDnDRX9eBFs1n7gQRMYw7bfhmkRAfIH6BN5WB9nMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=diWQR9TEt3UYS9+2tT9lEhJN+ff9B5sdFzmATTwNoRknwtI+iB/uRLDhks+N4DPbpNMua/4Evg6dNpSj7eGmSu3laBBqnHqj3f7UOJeFcR4KLRuGy+R7WBvYb0DQs24KLFk66/OR+oMiu0PmPI4U0cbw0OlJhtVVHBtWUBbDeH6aPAK+0cmBiRyHp/7TJzVgdJ9NBIklRKmFOwmiVCYf4PL++2nl0HfdfxqZfLj3yLIDDTMCWrUPVNVArnQwZnmGadG/ZQJ43aEgBYhrkEN0TF6Gu8T6CaAIDYmfwbQHbKZxlXXEvvjzuZBB856U+VhxL++TLu6YuN6IKvDd6NGemQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 16 Aug 2019 16:28:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVU6LQhgr4s3/gv0qSGrHMU43t3Kb9+AMA
- Thread-topic: [PATCH] xen/arm: domain_build: Remove redundant check in make_vpl011_uart_node()
Hi Julien,
Julien Grall writes:
> None of the code since the last check of res modify the value. So the
> check can be removed.
>
> Coverity-ID: 1476824
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> ---
> xen/arch/arm/domain_build.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index cf9ffbc360..173544d8c5 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1629,8 +1629,7 @@ static int __init make_vpl011_uart_node(const struct
> domain *d, void *fdt)
> dt_child_set_range(&cells, GUEST_ROOT_ADDRESS_CELLS,
> GUEST_ROOT_SIZE_CELLS, GUEST_PL011_BASE,
> GUEST_PL011_SIZE);
> - if ( res )
> - return res;
> +
> res = fdt_property(fdt, "reg", reg, sizeof(reg));
> if ( res )
> return res;
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
