Re: [Xen-devel] [PATCH v2] Allow get_maintainer.pl / add_maintainers.pl scripts to be called outside of xen.git

[Lars Kurth <lars.kurth.xen@xxxxxxxxx>]

> On 16 Aug 2019, at 14:28, Julien Grall <julien.grall@xxxxxxx> wrote:
> 
> 
> 
> On 16/08/2019 13:17, Lars Kurth wrote:
>> On 16/08/2019, 11:01, "Julien Grall" <julien.grall@xxxxxxx> wrote:
>>      From my understanding, any use on mini-os.git & co will be legitimate. 
>> However,
>>     we still print the WARNING in those cases.
>>          Usually WARNING means something needs attention. As most of the 
>> users will
>>     likely copy/paste from the wiki, we are going to have report asking why 
>> the
>>     WARNING is there.
>>          I think it would make sense to try to downgrade the message a bit 
>> when possible.
>>     For instance, we could check if the section "THE REST" is present in the 
>> file
>>     MAINTAINERS. If not, this is likely not a file we are able to support.
>>     I thought about this and it is not as easy as it seems, because the 
>> script only parses
>> M: ... &c lines
> 
> The script is able to parse the section name. See get_maintainer_role().
> 
> Although, I am not sure how early the function can get called.
> 
> But...

That may make it feasible to go down that route.
Incidentially both Linux as well as QEMU MAINTAINERs files use the same syntax
as us (with a few extra tags which we don't have)

Not sure whether this would be a problem

>> Maybe the best way to address this would be to include some identifier into 
>> the
>> MAINTAINERS file (after the header with all the definitions).
>> FORMAT: xen-project-maintainers <version>
>> (note that this is not currently picked up by the tool)
>> Or
>> V: xen-project-maintainers <version>
>> (note that this would be picked up by the tool)
> 
> Any of these solutions are also a potential alternative.

I will see what others think and take it from there

Lars


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel