[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [livepatch-build-tools part2 v2 6/6] create-diff-object: Do not include all .rodata sections

  • To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
  • From: "Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>
  • Date: Fri, 16 Aug 2019 12:08:16 +0000
  • Accept-language: en-US
  • Cc: "Pohlack, Martin" <mpohlack@xxxxxxxxx>, "Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 16 Aug 2019 12:11:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVTeZOIZEoFX4igUei1sh+3wGHf6b9liEAgAAkpAA=
  • Thread-topic: [livepatch-build-tools part2 v2 6/6] create-diff-object: Do not include all .rodata sections

On 16. Aug 2019, at 11:57, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx> wrote:

On 8/8/19 1:39 PM, Pawel Wieczorkiewicz wrote:


 #define inc_printf(fmt, ...) \
  log_debug("%*s" fmt, recurselevel, "", ##__VA_ARGS__);
This patch looks good. There is a comment at the top of should_include_str_section() which should probably be updated as well:

* String sections are always included even if unchanged.
* The format is either:
* .rodata.<func>.str1.[0-9]+ (new in GCC 6.1.0)
* or .rodata.str1.[0-9]+ (older versions of GCC)
* For the new format we could be smarter and only include the needed
* strings sections.

Oh yes, right. Let me update the comment. Thanks!

In fact, it is probably a good idea to rename the function to something like "is_rodata_str_section()" since this more accurately describes what it does now.

ACK, will do.

Ross Lagerwall

Best Regards,
Pawel Wieczorkiewicz

Attachment: signature.asc
Description: Message signed with OpenPGP

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.