[Xen-devel] [Qemu-devel] [PATCH v7 17/42] hw/char: Declare device little or big endian

[<tony.nguyen@xxxxxx>]

For each device declared with DEVICE_NATIVE_ENDIAN, find the set of

targets from the set of target/hw/*/device.o.

If the set of targets are all little or all big endian, re-declare

the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN

respectively.

This *naive* deduction may result in genuinely native endian devices

being incorrectly declared as little or big endian, but should not

introduce regressions for current targets.

These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it

has a new target with an opposite endian or 2) someone informed knows

better =)

Signed-off-by: Tony Nguyen <tony.nguyen@xxxxxx>

---

 hw/char/cadence_uart.c   | 2 +-

 hw/char/escc.c           | 2 +-

 hw/char/etraxfs_ser.c    | 2 +-

 hw/char/grlib_apbuart.c  | 2 +-

 hw/char/imx_serial.c     | 2 +-

 hw/char/lm32_uart.c      | 2 +-

 hw/char/milkymist-uart.c | 2 +-

 hw/char/pl011.c          | 2 +-

 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c

index fa25fe2..6c7b904 100644

--- a/hw/char/cadence_uart.c

+++ b/hw/char/cadence_uart.c

@@ -457,7 +457,7 @@ static uint64_t uart_read(void *opaque, hwaddr offset,

 static const MemoryRegionOps uart_ops = {

     .read = uart_read,

     .write = uart_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static void cadence_uart_reset(DeviceState *dev)

diff --git a/hw/char/escc.c b/hw/char/escc.c

index 8ddbb4b..36182d9 100644

--- a/hw/char/escc.c

+++ b/hw/char/escc.c

@@ -574,7 +574,7 @@ static uint64_t escc_mem_read(void *opaque, hwaddr addr,

 static const MemoryRegionOps escc_mem_ops = {

     .read = escc_mem_read,

     .write = escc_mem_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_BIG_ENDIAN,

     .valid = {

         .min_access_size = 1,

         .max_access_size = 1,

diff --git a/hw/char/etraxfs_ser.c b/hw/char/etraxfs_ser.c

index 9745bca..cda687b 100644

--- a/hw/char/etraxfs_ser.c

+++ b/hw/char/etraxfs_ser.c

@@ -155,7 +155,7 @@ ser_write(void *opaque, hwaddr addr,

 static const MemoryRegionOps ser_ops = {

     .read = ser_read,

     .write = ser_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

     .valid = {

         .min_access_size = 4,

         .max_access_size = 4

diff --git a/hw/char/grlib_apbuart.c b/hw/char/grlib_apbuart.c

index c2bb3ac..119fc84 100644

--- a/hw/char/grlib_apbuart.c

+++ b/hw/char/grlib_apbuart.c

@@ -237,7 +237,7 @@ static void grlib_apbuart_write(void *opaque, hwaddr addr,

 static const MemoryRegionOps grlib_apbuart_ops = {

     .write      = grlib_apbuart_write,

     .read       = grlib_apbuart_read,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_BIG_ENDIAN,

 };

 

 static void grlib_apbuart_realize(DeviceState *dev, Error **errp)

diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c

index 0655a95..7c66551 100644

--- a/hw/char/imx_serial.c

+++ b/hw/char/imx_serial.c

@@ -332,7 +332,7 @@ static void imx_event(void *opaque, int event)

 static const struct MemoryRegionOps imx_serial_ops = {

     .read = imx_serial_read,

     .write = imx_serial_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static void imx_serial_realize(DeviceState *dev, Error **errp)

diff --git a/hw/char/lm32_uart.c b/hw/char/lm32_uart.c

index d047a44..2fe5f60 100644

--- a/hw/char/lm32_uart.c

+++ b/hw/char/lm32_uart.c

@@ -205,7 +205,7 @@ static void uart_write(void *opaque, hwaddr addr,

 static const MemoryRegionOps uart_ops = {

     .read = uart_read,

     .write = uart_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_BIG_ENDIAN,

     .valid = {

         .min_access_size = 4,

         .max_access_size = 4,

diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c

index 8a78fcc..bdb8282 100644

--- a/hw/char/milkymist-uart.c

+++ b/hw/char/milkymist-uart.c

@@ -156,7 +156,7 @@ static const MemoryRegionOps uart_mmio_ops = {

         .min_access_size = 4,

         .max_access_size = 4,

     },

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_BIG_ENDIAN,

 };

 

 static void uart_rx(void *opaque, const uint8_t *buf, int size)

diff --git a/hw/char/pl011.c b/hw/char/pl011.c

index c1ae2f3..5fb95d2 100644

--- a/hw/char/pl011.c

+++ b/hw/char/pl011.c

@@ -287,7 +287,7 @@ static void pl011_event(void *opaque, int event)

 static const MemoryRegionOps pl011_ops = {

     .read = pl011_read,

     .write = pl011_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static const VMStateDescription vmstate_pl011 = {

-- 

1.8.3.1

​

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel