Re: [Xen-devel] [PATCH] Allow get_maintainer.pl / add_maintainers.pl scripts to be called outside of xen.git

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 15/08/2019, 18:12, "Lars Kurth" <lars.kurth@xxxxxxxxxx> wrote:

    Use-case: Allow using both scripts on xen repositories such as
    mini-os.git, osstest.git,
    
    Tool changes:
    * add_maintainers.pl: $get_maintainer inherits path from $0
    * get_maintainer.pl: warn (instead fo die) when called
      from a different tree
    
    Assumptions: the repository contains a MAINTAINERS file that
    follows the same conventions as the file in xen.git
    
    A suggested template
    
    ========================================================
    This file follows the same conventions as outlined in
    xen.git:MAINTAINERS. Please refer to the file in xen.git
    for more information.
    
    THE REST
    M:  MAINTAINER1 <maintainer1@xxxxxxxxx>
    M:      MAINTAINER2 <maintainer2@xxxxxxxxx>
    L:  xen-devel@xxxxxxxxxxxxxxxxxxxx
    S:  Supported
    F:  */
    ========================================================
    
    Signed-off-by: Lars Kurth <lars.kurth@xxxxxxxxxx>
    ---
     scripts/add_maintainers.pl |  9 ++++++---
     scripts/get_maintainer.pl  | 13 +++++++++++--
     2 files changed, 17 insertions(+), 5 deletions(-)
    
    diff --git a/scripts/add_maintainers.pl b/scripts/add_maintainers.pl
    index 09e9f6609f..7f98dde874 100755
    --- a/scripts/add_maintainers.pl
    +++ b/scripts/add_maintainers.pl
    @@ -25,10 +25,13 @@ sub normalize ($$);
     sub insert ($$$$);
     sub hastag ($$);
     
    -# Tool Variables
    -my $get_maintainer      = "./scripts/get_maintainer.pl";
    -
    +# Tool Variables 
     my $tool = $0;
    +my $get_maintainer = $tool; 
    +$get_maintainer =~ s/add_maintainers/get_maintainer/; 
    +
    +print $get_maintainer."\n";

Will re-send a v2. I left a debug message in. Apologies
Lars    

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel