[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: "YOUNG, MICHAEL A." <m.a.young@xxxxxxxxxxxx>
  • Date: Tue, 13 Aug 2019 21:51:18 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=durham.ac.uk; dmarc=pass action=none header.from=durham.ac.uk; dkim=pass header.d=durham.ac.uk; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6msSZoCAjcrK0l/0e1dhr9vBeFsYQu4RNIfsaeyp050=; b=YjZLiHmrgP3cd6cZnT9iYhAKDbkYxXfafdkcrhpyf6jDtCGFUxnpF+hC2BbBCX3bsoXVoYz9aEF322+UlSa7cuPrbi9tdVcvB7ykUt/uNm2LuivOlmimWePjQ2EwzePSKD5Qi3gED4I3N596XEI1/Ngw3HKJhU0+4jFiDn/ic3U1aB3pzITymTSG/tDlqtwOQm41oPQcX1M2FSvzYuxekOclKUZqErAopJsJiwe4Gglo0PkXPORWptEN5+2pItnP4hKgJ/wsQqxs7OuKyXegVwAXHztSjI+0XfTGYh630OpCaE+VIttVkGG4hz00mV59+GtVHmHq/DpPLCKQ+mL4iw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KcTEkdqDGbqEUi8pn5FsiDOCm9wKzK+vICXpPbTWzMYWKXhLP3tkC2pUdMxDMeBPTL+44rMIeVB3zkVkGRm/TtKlpunFfddcK0sR1SdvwqsHhwAVHfhLDlj6WqCsOaFfGxnu4h31Wv6vA0vOSM5C/02q7Z140zL04RGJnWj/F383m4g1s+S5PWM9XhsNq4+39PaMWR1HQ7GCluDXI6Zln/4hOBPwOUWBIw2Wdlr2wAWP9wsWdh+UlvYLiNaP2DU0DQcyFh63bX/agP2AdBQPtvm/6DeTLEnIwl5tD/8XnpOOtJ5iVa++zFc3mu/v4vGvU7yF9lfnHLBJkeaDJ97qQA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=m.a.young@xxxxxxxxxxxx;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Steven Haigh <netwiz@xxxxxxxxx>
  • Delivery-date: Tue, 13 Aug 2019 21:51:33 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVUhpuA7gOz+/Ark2RBY58DX7TkKb5kqGAgAALn4A=
  • Thread-topic: [Xen-devel] [PATCH] failing to set value to 0 in Grub2ConfigFile

On Tue, 13 Aug 2019, Andrew Cooper wrote:

> On 13/08/2019 22:02, YOUNG, MICHAEL A. wrote:
>> I have been looking at the pygrub code to see if it is possible to cope
>> with grub files with BLSCFG and spotted this minor issue in GrubConf.py
>> where the code intends to replace ${saved_entry} and ${next_entry} with 0
>> but doesn't succeed.
>> Signed-off-by: Michael Young <m.a.young@xxxxxxxxxxxx>
> Ah - this looks suspiciously like it might be the bugfix for an issue
> reported by Steven.
> Steven - do you mind giving this patch a try for your "Fedora 30 DomU -
> pygrub always boots the second menu option" problem?

Sadly I don't think it is that simple and to it properly would require 
parsing if clauses in the grub file and also reading variables from the 
grubenv file.

I do however have an idea which might work which is to ignore anything in 
if clauses, read the grubenv file (which I now have a hacky way of doing) 
and treating the value of next_entry or saved_entry as the setting for
the default kernel to pick. If I finish a patch that does this I will post
it on the list, but I very much doubt it will be of commitable quality.

        Michael Young

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.