Re: [Xen-devel] [PATCH] xen/page_alloc: Keep away MFN 0 from the buddy allocator

[Jan Beulich <jbeulich@xxxxxxxx>]

On 09.08.2019 20:34, Stewart Hildebrand wrote:
> On Friday, August 9, 2019 2:24 PM, Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > On Fri, 9 Aug 2019, Stewart Hildebrand wrote:
> > > Here is Jeff's initial patch for the issue.
> > I committed Julien's patch for now,
> Great! Thanks!
>
> > but if we need to make any changes
> > or decide for a better alternative, we can always revert it.
> Can we entertain committing both patches?
> To paraphrase George from an earlier discussion: Removing MFN 0 fixes the issue 
> by relying on side effects. Adding an explicit check in the merging logic 
> directly fixes the issue.
I thought previous discussion (when you had first posted you variant
of the fix) had clarified that there are objections to you modifying
an often executed code path when the same effect can be achieved by
modifying an infrequently executed one.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel