[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 2/6] xen: add a p2mt parameter to map_mmio_regions
On 07.08.2019 02:23, Stefano Stabellini wrote: Add a p2mt parameter to map_mmio_regions, pass p2m_mmio_direct_dev on ARM and p2m_mmio_direct on x86 -- no changes in behavior. On x86, introduce a macro to strip away the last parameter and rename the existing implementation of map_mmio_regions to map_mmio_region. Use map_mmio_region in vpci as it is x86-only today. On ARM, given the similarity between map_mmio_regions after the change and map_regions_p2mt, remove un/map_regions_p2mt. Also add an ASSERT to check that only p2m_mmio_* types are passed to it. Also fix the style of the comment on top of map_mmio_regions since we are at it. Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx> I guess apart from the naming question (see other sub-thread) I'm fine with this. However, ... --- xen/arch/arm/acpi/domain_build.c | 4 ++-- xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/gic-v2.c | 3 ++- xen/arch/arm/p2m.c | 19 ++----------------- xen/arch/arm/platforms/exynos5.c | 6 ++++-- xen/arch/arm/platforms/omap5.c | 12 ++++++++---- xen/arch/arm/traps.c | 2 +- xen/arch/arm/vgic-v2.c | 2 +- xen/arch/arm/vgic/vgic-v2.c | 2 +- xen/arch/x86/hvm/dom0_build.c | 2 +- xen/arch/x86/mm/p2m.c | 8 ++++---- xen/common/domctl.c | 7 ++++++- xen/drivers/vpci/header.c | 2 +- ... these two and ... xen/include/asm-arm/p2m.h | 15 --------------- xen/include/asm-x86/p2m.h | 8 ++++++++ xen/include/xen/p2m-common.h | 11 +++++++---- ... this one require you to widen the Cc list. This would the also allow George to become more aware of the asm-x86/p2m.h change, which strictly by ./MAINTAINERS he may not need to ack, but which is part of "X86 MEMORY MANAGEMENT" really. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |