[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/4] enhance lock debugging

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Thu, 8 Aug 2019 09:08:40 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v0Qd02xcGRBAjPiuayho39yWzBZseheArZOaY3Udddg=; b=fbkPGcSMqfoh+Le/Nnm+0zO1lOEL8XGjrhDGtoQHbm87fYrLutFOEtqlpZv0S3Rcthh4lFaJYdBngbgpGia66qE0zwRcsE7MX5u8J7BgacO0PtAdtihD4/cmffF2LBubO+jPOzcTsKPJ+VZqk0KsK8uLaXNRdHfEArYP3QSR38KovlamjbvjzuJxioo/Q9s5uqk7VnU4P6f9c1wPCpJT4dRxmWSh3qY1PnBQw+8mj561FftWXRWsKMeJpalPI5sC6+yEBmlMAqI6WTeb6H8F1gpo1IVwLanY2nq7dtr/DGGsol2wRpOw0QTBYURGNoZRdlfiNb5yNbx+F35verjnBg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KUHSHzZieuZmUHVe1qG5x/YXJsCkpfGaPIGVPQwm5ONFcIpYiEUD46KQkrXKd4cVO81PuW0nu56s7z9dg4LYyNAG+vS6qTT08Ka2uXPGZ+4jJ7+gOrYroV6tl0DrH0yJyKs5wSgB08y/eqngBnNKIHSXtlvjF3SpcbFTTSixoP7SaMcVjjf3LdFeQqC2t/BztOMowbBu7EiCMWfx26K94aBF+SXz3G27siZgoQ1bQGjG6C1lEsd1qvIs1IgC/Tc+Us7rANrnQBfuMbpbqc4AG3/3z5PUaNcyx5FtnM1FU6rKcbsuxUqpCjnSQtYai/CSx5kdu3MdY+xIveqSM9/Zow==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Juergen Gross <JGross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, WeiLiu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 08 Aug 2019 09:11:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVTaTjLrtftDrvKkCKqSelFkELw6bw7JlBgAAJ1oA=
  • Thread-topic: [PATCH 0/4] enhance lock debugging

On 08.08.2019 10:33, Andrew Cooper wrote:
> On 08/08/2019 05:50, Juergen Gross wrote:
>> On 07.08.19 20:11, Andrew Cooper wrote:
>>> <snip>
>>> Its not exactly the easiest to dump to follow.
>>> First of all - I don't see why the hold/block time are printed like
>>> that.  It
>>> might be a holdover from the 32bit build, pre PRId64 support.  They
>>> should
>>> probably use PRI_stime anyway.
>> Fine with me.
>>> The domid rendering is unfortunate.  Ideally we'd use %pd but that would
>>> involve rearranging the logic to get a struct domain* in hand.
>>> Seeing as
>>> you're the last person to modify this code, how hard would that be to
>>> do?
>> It would completely break the struct type agnostic design.
> Ok.  As an alternatively, how about %pdr which takes a raw domid?  It
> would be a trivial adjustment in the vsnprintf code, and could plausibly
> be useful elsewhere where we have a domid and not a domain pointer.

At the risk of upsetting / annoying you: A domid_t would again
better be formatted via %od (and without the need to take the
address of a respective variable). In the case here it would
have the minor additional benefit of conserving on format string

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.