[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 2/4] xen: add new CONFIG_SPINLOCK_DEBUG option
- To: Juergen Gross <JGross@xxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 8 Aug 2019 07:35:40 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qaNR5ijRICDMK3qbDtG6Lmn/Zhdbg7gZlU9gW4uzP1k=; b=ZMCP/bBdxMo8jiFfa2/2zosjxPQA0aydf98tYohmEhZif+hMsNO/nzKyVqr9MVwIUZdKU30n8AthsKg9a4xc5WlV+38hNUn6VLEmYCvejW2vFNKrJB6aa711zntPsR46Om5SqNkJhQBofEGpREDhAJSBnh/um4D50MmqjlmUeGwVI8YNxd4GlylHP/xnFqwmi6PvitrL2sw1aBoCl3sY3dVbqym2w1auvXQPH6J2kC83w/NvgJc1cOlNFO5Tc7qijyl1Qp41lqNhFrZO4TgXcyJI6h7xBqrUocPWzblheWlHs8sQdK5UTrdlFJrcognz20NcDiwbaesuR5ovd2seBw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffKvZCBo6W/nkUKusVHUUK8zQ8q4TlwCpoMZ5fTj6pArbXHowy5NRZsbp4bHcWNKzIAs77KsbxLzOb4PKJiQSFhrJol4jxLDYho85vFL/EkVe1bMZIvv2LnU+6WdsFrnQTdyLT8ShSrDAMIabgH57veDcy62Kwvliij7h2FTP7A7eOmbGvXHvRyqC1wmY4skQqxTT9Pk/QyFbGVTun+cCFxWEs1/AX8ZYmPsCW8Ta5Awt0cYF3MzEw5tesAOVDHOgClEFKVX8IjwjiBrqVT4e/D2jAW01Ql8Ux5wVKkjvHdfkMFcje/qhHLwJUt3bO9sgO2k5FvpbyPjAHPYPV3nBQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 08 Aug 2019 07:39:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVTSzXKk23fauQiUyiEfLANmxBAKbw7fkA///sPUaAAAMtgA==
- Thread-topic: [PATCH 2/4] xen: add new CONFIG_SPINLOCK_DEBUG option
On 08.08.2019 09:23, Juergen Gross wrote:
> On 08.08.19 08:34, Jan Beulich wrote:
>> On 07.08.2019 16:31, Juergen Gross wrote:
>>> --- a/xen/Kconfig.debug
>>> +++ b/xen/Kconfig.debug
>>> @@ -44,6 +44,13 @@ config COVERAGE
>>> If unsure, say N here.
>>> +config SPINLOCK_DEBUG
>>> + bool "Spinlock debugging"
>>> + default DEBUG
>>> + ---help---
>>> + Enable debugging features of spinlock handling. Some additional
>>> + checks will be performed when acquiring and releasing locks.
>>> +
>>> config LOCK_PROFILE
>>
>> While the pre-existing LOCK_PROFILE suggests the opposite, I'd
>> still like to propose that we uniformly name all debugging
>> options CONFIG_DEBUG_* (rather than having the DEBUG at the
>> end). Thoughts?
>
> Fine with me. I can rename the LOCK_PROFILE option in patch 4 as I'm
> touching it anyway.
One more thing: Perhaps it would better be DEBUG_LOCK (i.e.
without "SPIN") or DEBUG_LOCKS, to also allow it to cover r/w
locks, should anyone want to instrument them as well.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
