Re: [Xen-devel] [PATCH V4] tools/libxl: Add iothread support for COLO

["Zhang, Chen" <chen.zhang@xxxxxxxxx>]

Ping...
Any comments?

Thanks
Zhang Chen


> -----Original Message-----
> From: Zhang, Chen
> Sent: Saturday, July 27, 2019 12:27 AM
> To: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Anthony
> PERARD <anthony.perard@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Zhang Chen <zhangckid@xxxxxxxxx>; Zhang, Chen <chen.zhang@xxxxxxxxx>
> Subject: [PATCH V4] tools/libxl: Add iothread support for COLO
> 
> From: Zhang Chen <chen.zhang@xxxxxxxxx>
> 
> Xen COLO and KVM COLO shared lots of code in Qemu.
> The colo-compare object in Qemu now requires an 'iothread' property since
> QEMU 2.11.
> 
> Detail:
> https://wiki.qemu.org/Features/COLO
> 
> Signed-off-by: Zhang Chen <chen.zhang@xxxxxxxxx>
> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>  tools/libxl/libxl_dm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index
> f4fc96415d..839c5ac2cd 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -1634,8 +1634,10 @@ static int
> libxl__build_device_model_args_new(libxl__gc *gc,
>                          nics[i].colo_compare_out &&
>                          nics[i].colo_compare_notify_dev) {
>                          flexarray_append(dm_args, "-object");
> +                        flexarray_append(dm_args, "iothread,id=colo-compare-
> iothread-1");
> +                        flexarray_append(dm_args, "-object");
>                          flexarray_append(dm_args,
> -                           GCSPRINTF("colo-
> compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,notify_dev=%s",
> +
> + GCSPRINTF("colo-compare,id=c1,primary_in=%s,secondary_in=%s,outdev=%s,
> + notify_dev=%s,iothread=colo-compare-iothread-1",
>                                       nics[i].colo_compare_pri_in,
>                                       nics[i].colo_compare_sec_in,
>                                       nics[i].colo_compare_out,
> --
> 2.17.GIT


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel