Re: [Xen-devel] [PATCH v3 1/5] xen: add a p2mt parameter to map_mmio_regions

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 10 Jul 2019, Julien Grall wrote:
> Hi Stefano,
> 
> The Arm code looks good to me. One comment below.

Should I take it as a acked-by?


> On 6/19/19 12:20 AM, Stefano Stabellini wrote:
> > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> > index e28ea1c85a..d88df11e09 100644
> > --- a/xen/arch/arm/p2m.c
> > +++ b/xen/arch/arm/p2m.c
> > @@ -1310,31 +1310,18 @@ static inline int p2m_remove_mapping(struct domain
> > *d,
> >       return rc;
> >   }
> >   -int map_regions_p2mt(struct domain *d,
> > +int map_mmio_regions(struct domain *d,
> >                        gfn_t gfn,
> >                        unsigned long nr,
> >                        mfn_t mfn,
> >                        p2m_type_t p2mt)
> >   {
> > +    ASSERT( p2mt == p2m_mmio_direct_dev ||
> > +            p2mt == p2m_mmio_direct_nc ||
> > +            p2mt == p2m_mmio_direct_c );
> 
> Could you introduce p2m_is_mmio(...) in p2m.h?

Good idea, I'll do that in a prior patch and use it here.


> >       return p2m_insert_mapping(d, gfn, nr, mfn, p2mt);
> >   }


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel