[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/xl: Make extra= usable in combination with cmdline=

On Mon, Aug 05, 2019 at 03:49:10PM +0100, Andrew Cooper wrote:
> c/s 986aea7fbe "xl.cfg: add 'cmdline' in config file" introduced cmdline= and
> make extra= and root= unusable if cmdline= was present.
> For the vm.cfg file itself, this makes sense.  However, for development
> purposes it is very convenient to have a cmdline= in the cfg file, and specify
> extra= on the `xl create` command line.
> While updating the manpage, correct the entry for cmdline=.  There is never
> any appending which goes on with this option, but after this change extra= may
> be appended to cmdline=.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> In particular, this is useful for testing Xen as a PVH guest, where switching
> between a PV and PVH dom0 involves adding "dom0=pvh dom0-iommu=none" to
> command line.  Now, given a single build of Xen under test, two tests can be
> run with just
>  # xl create shim.cfg ramdisk=\"test-pv64-example\"
> and
>  # xl create shim.cfg ramdisk=\"test-hvm64-example\" extra=\"dom0=pvh\ 
> dom0-iommu=none\"
> without needing to edit shim.cfg inbetween.

:(, this feels like the wrong approach. It is time to invent += ? So we
can do cmdline+="x", disk+=['xvdz'], ... :-).

The `cmdline' option have been there for sometime, so hopefully no one
has both `cmdline' and `extra' in there config file and changing the
meaning of extra would be ok.

With that in mind, the patch looks fine,
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>


Anthony PERARD

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.