[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices


  • To: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Mon, 5 Aug 2019 15:51:55 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/vvq6l/nAVJt3c1Ous9hQzynCcj6yq0AIpEucZZGoCI=; b=PkQFnto0c/kuVkavHWbEcnGPHNxBJLNd9BQOcpGph7S3uT90qzkz/xs+sIWfzW1Kqhyp3BZ9YJjDD4ocwQV3/Bar3vcCqOmKNdNsg27Ho71B4drkyJoz4uX3+W+V1clGOcsQsj5KrcNE/IwMoVc93QGulYhCLJCo6MCLoVJx68psLl5PN4bhVmPQbbGhqMCG7QmNFns74E4NpzmAYlPgC9gIpk2f5PsHeviHsJvwjOSsV5vMT99NhK+qBEtyTW6Cb3S8i2dpr8uLnBbvGqOKdd+wE00bGpsPaP626L+zNel9SwEtZF85lRIXSn1erVdo/YRXrDRY2vSeR0UD9vv0jA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBR9uD3CkX3S+uPdWHFxuzx8UB7JtwYsvbJvM+n16aG8b4gg1g2gVNOT8UOYFJ7bMfzvKehJnEDL765RPV5EWMZSlDJ5My4h4OOckjokl8l08Zw+9NtqbJfcpI0joZyM81846k4edDWIQP9py1twJlqdxfcZYLj0WHV21AJhuzP00OJuvS4odXr+paqR5l6eiP+1c9byRKcmwuODfWBgx8BsfdK3n+x2tcVE2UP+yKEWJwja5vcuLKdJIxJd8Wk/MC9cA1prnuFUUEDmYRDNmvI1g3/zbxNn9QeQ22zCvwUP4wV7jY75S3PLwqcsKaRIwDF842C3dw+Q3PbhTuIn4w==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
  • Delivery-date: Mon, 05 Aug 2019 15:53:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVS51JH2NAarmoikCRSWu51JcdnabstCeA
  • Thread-topic: [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices

On 05.08.2019 16:50, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH] libacpi: report PCI slots as enabled only 
> for hotpluggable devices"):
>>>>> On 23.05.19 at 17:20, <wei.liu2@xxxxxxxxxx> wrote:
>>> On Thu, May 23, 2019 at 02:57:49AM -0600, Jan Beulich wrote:
>>>>>>> On 22.05.19 at 20:10, <igor.druzhinin@xxxxxxxxxx> wrote:
>>>>> DSDT for qemu-xen lacks _STA method of PCI slot object. If _STA method
>>>>> doesn't exist then the slot is assumed to be always present and active
>>>>> which in conjunction with _EJ0 method makes every device ejectable for
>>>>> an OS even if it's not the case.
>>>>>
>>>>> qemu-kvm is able to dynamically add _EJ0 method only to those slots
>>>>> that either have hotpluggable devices or free for PCI passthrough.
>>>>> As Xen lacks this capability we cannot use their way.
>>>>>
>>>>> qemu-xen-traditional DSDT has _STA method which only reports that
>>>>> the slot is present if there is a PCI devices hotplugged there.
>>>>> This is done through querying of its PCI hotplug controller.
>>>>> qemu-xen has similar capability that reports if device is "hotpluggable
>>>>> or absent" which we can use to achieve the same result.
>>>>>
>>>>> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
>>>>
>>>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>>
>>>
>>> Jan, FAOD since you're the maintainer I'm expecting you to push this
>>> patch yourself.
>>
>> Sure, I have it on my list of things to push.
> 
> Is this a backport candidate ?  It sounds like it might be a bugfix
> but I don't understand the risks/implications.

I did already take the liberty of backporting this (back in June).

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.