[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools: ipxe: update for fixing build with GCC9


  • To: Wei Liu <wl@xxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Mon, 5 Aug 2019 15:30:09 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Dario Faggioli <dfaggioli@xxxxxxxx>
  • Delivery-date: Mon, 05 Aug 2019 14:30:54 +0000
  • Ironport-sdr: I7PrfdxZutIYErbprfsMm0uIz+rGLe8Af3yXgS/aul2DIaHs/XcCr0PCdgE0/C7bUJvCA35WWY 61tMlDKMPBt/oTSrACj0DOmkkEMlIfupACUs9gvoK6hFZ+FebJpWdQT29RtFgWQefNeMBmT5LM UoC99EM6lFtf3yq+l+lsdGDLAKS/y5El87EBS6BJr9YiFMuQ6o8Ov31sfv4SKoNpLW1dkZZ67i yHXY+BaxBhWUMn+kc4gaNNE8I9Ize1Nsrv9r6QsjMGhZG/oTrBtOJrUaxGMKndZ29JPptQh8ac Y6A=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Wei Liu writes ("Re: [Xen-devel] [PATCH] tools: ipxe: update for fixing build 
with GCC9"):
> On Sat, Jul 27, 2019 at 12:13:49AM +0200, Dario Faggioli wrote:
> > Building with GCC9 (on openSUSE Tubmleweed) generates a lot of errors of
> > the "taking address of packed member of ... may result in an unaligned
> > pointer value" kind.
> > 
> > Updating to upstream commit 1dd56dbd11082 ("[build] Workaround compilation
> > error with gcc 9.1") seems to fix the problem.
> > 
> > For more info, see:
...
> Yes this is what we normally do.
> 
> Acked-by: Wei Liu <wl@xxxxxxx>

Thanks all.  Should this be backported anywhere ?  I'm inclined to say
"no" because someone who wants this can easily change it themselves,
and we don't want to disturb stable users with an ipxe version update.

But I'm open to opinions.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.