[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 2/2] xen/arm: consolidate make_timer_node and make_timer_domU_node

On Thu, Aug 1, 2019 at 5:50 PM Volodymyr Babchuk
<Volodymyr_Babchuk@xxxxxxxx> wrote:

> >> In this case we also can declare and use intrs[] in the same way.
> >
> > There is no guarantee the index in irq will match intrs[...]. So you
> > need to keep them hardcoded in the latter case.
> Oh, right.

I don't like the idea of using hardcoded numbers in the code. BTW,
Misra rule says it should not be used as well. However, in this case,
I did not change it, because it should be done in another patch.
Anyway, hardcoded numbers should be avoided in the code, it seems this
is a good candidate for a new Xen coding style rule if we want to
achieve Misra compliance someday.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.