[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] CODING_STYLE: clarify function argument indentation

On Wed, Jul 31, 2019 at 05:57:32PM +0000, Volodymyr Babchuk wrote:
> Lars Kurth writes:
> > Ultimately we have to make some trade-offs as to what is more important:
> > a) automatic style checking - which means "common sense" can't be 
> > formalised and there will be boundary cases like the above
> > b) reclaiming code review bandwidth through automation or going for a 
> > labour intensive manual approach
> I like the linux kernel approach.  checkpatch.pl produces errors, which are
> "no go", but it also produces warnings for such boundary cases, for
> maintainer/reviewer to decide.

Yes! QEMU also uses checkpatch.pl script and I found that very useful
(both as reviewer and author of a patch). It tells you what are the
coding style violation in newly added code and doesn't try to reformat
the whole file.

But that script would needs quite a lot of rewriting, I think, to be
able to be used on the multiple coding style of xen.git.

Anthony PERARD

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.