[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] build: allow picking the env values for toolchain utilities


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Mon, 29 Jul 2019 15:39:35 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IIiUxdVbPXmfyza3zv3iSMLo5pHSWyc/BxMgwNGb6KU=; b=PnBsqNAKDJUcYH6g2lheY3xYLVUPN6GTkYVtzqOcCEDtHs8iVEg2+jKTF31d1nb5Pc7Ydm+xi/jAC55eEI/DzGiyf086Dpyxj4fPNdNi+50FozYJt7yMjxvrk9pbwraD0uYRlIWXQLVYvaVlkMs3Dj/2Kov9yp9FfpKy08xdbzJavOepJOswStWHBlnVhLQjW49fbGoOFP3ya+K1UZVNW+OW+1Xdc6uyPMLsypTXe02iMmeuklpfTAKgDtn8rI2Vioc403Jfyog3tQaSzKbejrJxX97dhz+R/NdKCDhN9BsjaFoCWNBGDs0WkzByF4ZrEx101Deitw28s9cjqMYDKg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z920VFA4PdzE+eGT2cMUj8A2KY3f72cDtCOnfmrZmRCDnC+7In4fVuIcxj2kgFwXgTBQ77Lq2LQsgPzg4iKUknmdBO8S3e5woiIgXxHopWfNQuuuY2ZGZCFXlc1dMvqIZqWAQXG6z3I35AcH0A/JswGhRKeLygKrd7gDTCggKpUf2Zv1o2WQY55WFbwpsu1deSSGU4mcVrbef8Z4oKrCVeOYm0kIdYvBWjDcwJFd6UG8HGulviLIcQGydjmHAhgpkA5VWdY6kiYKCXCqYiOnev7xi7Iwrnvoaf/Ajq+pgc3xRT+gZMcy/x4zifNWEJTM4/ExedAzzdqo4kVTMG48Rw==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 29 Jul 2019 15:57:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVRiPSkFp+75VIl0mvuXFUmT434Q==
  • Thread-topic: [PATCH 3/3] build: allow picking the env values for toolchain utilities

On 26.07.2019 15:33, Roger Pau Monne wrote:
> --- a/config/StdGNU.mk
> +++ b/config/StdGNU.mk
> @@ -1,8 +1,6 @@
>   # Use Clang/LLVM instead of GCC?
>   clang     ?= n
>   
> -AS         = $(CROSS_COMPILE)as
> -LD         = $(CROSS_COMPILE)ld
>   ifeq ($(clang),y)
>   gcc       := n
>   DEF_CC     = clang
> @@ -28,19 +26,21 @@ HOSTCC    ?= $(DEF_CC)
>   HOSTCXX   ?= $(DEF_CXX)
>   endif
>   
> -CPP        = $(CC) -E
> -AR         = $(CROSS_COMPILE)ar
> -RANLIB     = $(CROSS_COMPILE)ranlib
> -NM         = $(CROSS_COMPILE)nm
> -STRIP      = $(CROSS_COMPILE)strip
> -OBJCOPY    = $(CROSS_COMPILE)objcopy
> -OBJDUMP    = $(CROSS_COMPILE)objdump
> -SIZEUTIL   = $(CROSS_COMPILE)size
> +AS        ?= $(CROSS_COMPILE)as
> +LD        ?= $(CROSS_COMPILE)ld
> +CPP       ?= $(CC) -E
> +AR        ?= $(CROSS_COMPILE)ar
> +RANLIB    ?= $(CROSS_COMPILE)ranlib
> +NM        ?= $(CROSS_COMPILE)nm
> +STRIP     ?= $(CROSS_COMPILE)strip
> +OBJCOPY   ?= $(CROSS_COMPILE)objcopy
> +OBJDUMP   ?= $(CROSS_COMPILE)objdump
> +SIZEUTIL  ?= $(CROSS_COMPILE)size

This does affect more than just the toolchain part of the tree,
doesn't it? Irrespective of this my point made for patch 2
applies here as well. Furthermore, if we were to go this route,
then SunOS.mk would want similar massaging.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.