[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 14/14] AMD/IOMMU: process softirqs while dumping IRTs


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: "Woods, Brian" <Brian.Woods@xxxxxxx>
  • Date: Fri, 19 Jul 2019 18:43:55 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=amd.com;dmarc=pass action=none header.from=amd.com;dkim=pass header.d=amd.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s1q2SKdNepYeKDQjfP756ZrpoTQxVAbMRgIi/wZuV2E=; b=k7LNCI9NPvzHV00V5WEcGRzPKhWkw+kZXyMR81mp3rxf9ALGww4FDhmDv+UHyNJags9Bil0cK+WjKoXEaoFSSFGn8qCmpFdU/mkIbGP/XtPte+0a5H5Ozlq002P+T/pAnxTiSHbqAkFLo/UoF6xrMtnnbr2Id9mp+QgZTCGAwc5NO+XpJl5gdB4PQA/PCD5dNUg0A9WF5mZeCURDXqfixr8Dn39gz0vzxqSVtFrB5mjAPILrlDbgoh4UiSlxrsyEhV8RIo0S8wZCEmmN3eJ23oe+k9D8XNYUCaZEi7A/UlmF+aKv64mWlbitzOjvjJhA6ywPbkxwDJXvk45xJ9qr4A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FnOXaFoKb78HcPE5Xhl6pCr6BYiS7dzwQCyki6L1cvTQu5PBKcLTJyemHoI65j2slpypzlU/UjwnRJV3lCg+gvdgKzPQnnU8YZO5p65N7qY/ICGIRrNfHo1mCO63n/suY2Z/Kj364UlqNGiQ1TlcjFOvscYwAJqktur8pzSBUgbRVpsbrUPzJpQ3+hqbUa9+v1XAIuLy7hQ/LVKiCsLQkWbaehICuxzMiCEVj3aGQ8ZPFPRSkYEvhqAvswaarU2Q+7DtLlguJXXeRDM+12CRaUKIV5wX954WqDju00OJS+bogWKbuB0viOw+4oak3XIqGgQsQAdDAMkVyoV6ouBzOg==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Brian.Woods@xxxxxxx;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Woods, Brian" <Brian.Woods@xxxxxxx>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Fri, 19 Jul 2019 18:44:04 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVO/VX3Kxfr5X6kUqWlRRaNiXYV6bSS+iA
  • Thread-topic: [PATCH v3 14/14] AMD/IOMMU: process softirqs while dumping IRTs

On Tue, Jul 16, 2019 at 04:41:21PM +0000, Jan Beulich wrote:
> When there are sufficiently many devices listed in the ACPI tables (no
> matter if they actually exist), output may take way longer than the
> watchdog would like.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Brian Woods <brian.woods@xxxxxxx>

> ---
> v3: New.
> ---
> TBD: Seeing the volume of output I wonder whether we should further
>       suppress logging headers of devices which have no active entry
>       (i.e. emit the header only upon finding the first IRTE worth
>       logging). And while minor for the total volume of output I'm
>       also unconvinced logging both a "per device" header line and a
>       "shared" one makes sense, when only one of the two can actually
>       be followed by actual contents.
> 
> --- a/xen/drivers/passthrough/amd/iommu_intr.c
> +++ b/xen/drivers/passthrough/amd/iommu_intr.c
> @@ -22,6 +22,7 @@
>   #include <asm/hvm/svm/amd-iommu-proto.h>
>   #include <asm/io_apic.h>
>   #include <xen/keyhandler.h>
> +#include <xen/softirq.h>
>   
>   struct irte_basic {
>       bool remap_en:1;
> @@ -917,6 +918,8 @@ static int dump_intremap_mapping(const s
>       dump_intremap_table(iommu, ivrs_mapping->intremap_table);
>       spin_unlock_irqrestore(&(ivrs_mapping->intremap_lock), flags);
>   
> +    process_pending_softirqs();
> +
>       return 0;
>   }
>   
> 

-- 
Brian Woods

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.