[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 06/60] xen/sched: move per-vcpu scheduler private data pointer to sched_unit
- To: Juergen Gross <JGross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Fri, 19 Jul 2019 17:10:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAbnYhZ7/TcDGbNAXyn8/ZH6+cuttk1Yepw50PyNZQA=; b=cYID73PTpUOVAUqBPbKrMeT7AJUlhXq3pleHfWHJrajI1Zs7SLt++9/9it0eAhtItlJbLcYA5l06kPUI+QievA7x+SXzUZxTBbZxBARJ30n0+z5/aLiSJ8j+f7XK3W/tKQWRoHRb8iwoitHuO2nhXV1BgJoE9LFrg1qJGbniYFWz2mlFvcvRKH2xJ9zGnOZC1OU9i2nJhtU/dq6JlvJEThzinSgr5HZFYoJiJEVaSltt7Z7zvlYjIn3PqHetKERWx2tJ7cV0xsL9RZga/w92Q4eiaEJ40k4Uoe+KwjWjk6hHQnjSHJ5CFctE0/kFqluFMq9mrzoNTa2k1LaxovZuXg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V/8GkLut6Xq0X3WVmLHsiFijGwie1XvYRtj21MAVN2bkGrlbS55W6qvWYp637sQcG7DBs8tWvSdgqaI7ECBmzD9bbOsf5lLxFYkH96S+AXb5LdUWHZYOeTLpgZ3NIQmizHVXhRWQPzOiv5AbklIuAtq5oJMoMatSGcJRQ4tl1Ic/FpWiN9jmF6H5+x9FfQL8JsA6Rr4d8ZvwsxZkIpeVMwM29QBfzpqAOCjlPET9K54SsWH4WnkGkacqaljHmmOtX5OBBmBKjK8lDl7SdZ86oxsYN/dW3AIfcNv8hAEC8qhTFi6JR6WQ/Z8Z5k4bubWQqO9aYdAu1Da6yGmajefC/A==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "robert.vanvossen@xxxxxxxxxxxxxxx" <robert.vanvossen@xxxxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, "josh.whitehead@xxxxxxxxxxxxxxx" <josh.whitehead@xxxxxxxxxxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
- Delivery-date: Fri, 19 Jul 2019 17:11:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPbuGcK2cLHKhs06MDcLPQ3t5r6bRY0VzgADLA4A=
- Thread-topic: [Xen-devel] [PATCH 06/60] xen/sched: move per-vcpu scheduler private data pointer to sched_unit
On Fri, 2019-07-19 at 07:03 +0200, Juergen Gross wrote:
> On 19.07.19 00:52, Dario Faggioli wrote:
> > On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote:
> > > This prepares making the different schedulers vcpu agnostic.
>
> > But shouldn't then the struct be called csched2_unit, and cited
> > functions be called csched2_alloc_udata() and csched2_unit()?
> > Now, I know that these transformation happen later in the series.
> > And, this time, I'm not asking to consolidate the patches.
> >
> > However:
> > - can the changelog of this patch be a little more explicit, not
> > only
> > informing that this is a preparatory patch, but also explaining
> > briefly the temporary inconcistency
>
> Sure.
>
Ok, thanks.
> > - could the patches that deal with this be grouped together, so
> > that
> > they are close to each other in the series [...]
>
> There are some patches which could be reordered, but I'm not sure the
> needed work is worth it. By moving the patches you named closer to
> each
> other there will be other closely related patches ripped apart from
> each other.
>
Yes, I appreciate that.
>
> In the end it will make no sense to apply only some patches of the
> main
> series. The huge amount of patches is meant only to make review
> easier.
>
And yet, this happens some times, especially for big series, and was
exactly what I was thinking to when making this comment.
Anyway, let's go with an updated changelog for now... And I'll build a
better and more solid opinion after having looked at the rest of the
series.
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
