[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 18 Jul 2019 15:13:40 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0rI7SWKJ2Rt5b79/U+BQgtSwKfNmRmvB+vHHNJq8fFI=; b=Ib6wZ3B1AvnCs6tyy6tS9uy2Y8Py+bBgdDW9o6IF9gI8jtEzT6m/WT/VdpOw9RSJZDoiOcOm5LtWDbFHmw5Vxen4mkXcUVgIG9J8uUxbzPxU4hOREkxlhhK2kq5WgdzG5HA3tWn6aUG7Syranw2JHOWJ7G+JHH0HY8BA2Te/GPFVQKq5fqmfD0mwro1ljMFekIrWu2z0C67r9bR3xh+bTK1braqTQyWWgGXK32cng5D3r9G4S7kwbVkHVnMgAJkNhrllzWQimUegfL2Lv9Rrk3FYPl+f+n8txEJku9lkZxfUgyzDw7gdIw7vXsbJ45DNR31fs+3YwVq2Ygij32+DEg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ce03qKn7blY0kVibTLy6bRBR9euhpsdXRO9stvpjvU6vzI+oidlByRpDR7cWMC6QewPMXsWvY4QxklJOdEp8xE/dwBUwD4A0V5LmDAgira19zyba8Ap3IiY/gqvuege5e9Spj3BuU4J1M/w3CvT9mq/c8jKoXsRd4rb07/excM8KMPCaLB6WYZywmeAZt6ytOFMuBS6TnDwPUgnjfah1gBzpkEdGOcedv/dvXZpVNAL7KxKHM2MKSFUzGKSTiPhIeH8+DDmtbchLcHHrItLRedKSv3KKTECUaK/MgctiEiJRUdw40ZTRuoGicYdK8xPbwBC7Ss/s7s5JoVc+Zyt5ag==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 18 Jul 2019 15:14:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPXcqh/rpHqCfrE2r6qBBgy1Fu6bQe86A
- Thread-topic: [RFC] xen: Add .astylerc for automated style-formatting
On 18.07.2019 16:43, Tamas K Lengyel wrote:
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -60,8 +60,8 @@ Bracing
> -------
>
> Braces ('{' and '}') are usually placed on a line of their own, except
> -for the do/while loop. This is unlike the Linux coding style and
> -unlike K&R. do/while loops are an exception. e.g.:
> +for the while-part of do/while loops. This is unlike the Linux coding style
> +and unlike K&R. do/while loops are an exception. e.g.:
>
> if ( condition )
> {
> @@ -77,7 +77,8 @@ while ( condition )
> /* Do stuff. */
> }
>
> -do {
> +do
> +{
> /* Do stuff. */
> } while ( condition );
I disagree with this change: There's a large number of (correct as
per the text prior to your change) instances, and since there's
nothing affecting the length of such lines avoiding the extra line
is quite desirable imo.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
