[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] IOMMU page-tables


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 18 Jul 2019 12:25:42 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=Pass smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; prefer-encrypt=mutual; keydata= mQINBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABtClBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPokCOgQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86LkCDQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAYkC HwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
  • Cc: Juergen Gross <JGross@xxxxxxxx>, "xen-devel\(xen-devel@xxxxxxxxxxxxxxxxxxxx\)" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx>, Lars Kurth <lars.kurth@xxxxxxxxxx>
  • Delivery-date: Thu, 18 Jul 2019 11:26:06 +0000
  • Ironport-sdr: MDv6UqsOaFk2w3o0viUu9d/fUqScXum3eu2zpEZc19dEKOKwZMCzZEeD5UtQpHStQc8QCTGHPf BA2FIs+HJVn4XGayHu5PNJhpBrJPJIuSJZ6YgzjBdwP+bYQ6CT2WMDDFbiMMMSWj6SmvODKF+V vsCniUTckZC+BFvw17w2+3LHGxUempsr1Db7hn+Qt/DyAMXMXdu32SEDG6aRML20uBPZXwBGnl 0sgLjx78Ep2+cfucYxe6pIFd8U/iyqxA9PslYjUB0r+eGTuYrriCgxYvFmy8FbehIxoUJBt8Av I9o=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Openpgp: preference=signencrypt

On 18/07/2019 12:16, Jan Beulich wrote:
> On 18.07.2019 12:13, Andrew Cooper wrote:
>> On 18/07/2019 10:49, Paul Durrant wrote:
>>> Hi,
>>>
>>>    Before I get too far into this I want to get some opinions from the 
>>> wider community...
>>>
>>>    At the moment when the first PCI device is assigned to a domain (i.e. 
>>> passed through) this will trigger construction of IOMMU page tables for 
>>> that domain. Similarly when the last PCI device is de-assigned the tables 
>>> are torn down again. Both of these operations can be quite expensive if the 
>>> domain is a large amount for RAM, and if the IOMMU does not support sharing 
>>> the second level CPU page tables (or the domain is PV). Moreover, the guest 
>>> could simultaneously be ballooning or doing other operations that affect 
>>> its page types and so the process of building the tables has to take into 
>>> account such races.
>>>    If we were instead to say that giving a domain IOMMU page tables is an 
>>> option that needs to be selected at domain create time then it makes the 
>>> code significantly simpler and there is no need to deal with page type 
>>> change/ballooning races any more. I hacked together a test patch and it 
>>> gets rid of roughly 200 lines of code (and there may be more that I missed).
>>>    Does anyone think that deciding whether a domain should get IOMMU page 
>>> tables is not a reasonable thing to have to do at create time?
>> To be absolutely clear here, I don't see any evidence for the current
>> behaviour to be a commonly used feature in practice.
>>
>> If anyone has a counterexample, please speak up urgently.
> I don't have a counterexample, nor am I outright opposed to the
> suggested change. Nevertheless I'd like to point out that "just
> in case" setting to IOMMU-enabled of a domain is a waste of
> memory if no device ever gets assigned to it.

In shared pagetable case, there is only some trivial accounting in Xen
AFACIT.

For the non-shared case, then yes - an extra 1% of the size of the
guest, in the worst case.

> And if there are
> people relying on being able to attach a device on demand, then
> they may be caught by surprise when they upgrade (and we all
> know how much documentation people read when they think they
> know what they're doing, which is to say: Adding a respective
> note to the release notes is not very likely to help.).

Our release notes are somewhere between poor and non-existent.  We can
definitely manage better, and there is no better time than now to make a
start.

In particular, we can try and highlight it during the RC's and test
days, which will probably be the best way for downstreams to notice. 
(CC'ing Lars and Juergen for visibility in their release capacities here.)

~Andrew

>
>> Furthermore, the complexity and (best-we-can-manage-security-wise)
>> livelocks in the hypervisor/toolstack is justification alone to
>> seriously consider dropping it moving forwards.  The complexity in
>> particular is an impediment to several aspects of IOMMU development work
>> which are in progress.
>>
>> In particular, I do not see it as an unreasonable burden for
>> admins/guests to specify whether they want an IOMMU at domain creation
>> time.  I expect that the overwhelming majority of cases already know at
>> creation time which PCI devices want assigning.
>>
>> As far as I'm concerned, this feature/corner case wants ripping out.
>> Whatever the original intention, hindsight has demonstrated that it
>> really isn't clever idea.
> FAOD - I agree with all the technical aspects here.
>
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.