[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 4/5] x86: allow limiting the max C-state sub-state


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Wed, 17 Jul 2019 09:07:29 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5wng67pIgFi4JK5NMBf7i91gPb5KsKTxR/TsZRlhpxw=; b=XDMjAM3qJYAmWI4YNy2jsgE4sVdVqptHDcfwcTjFUzRGpQ1rfBmackQGLCRw0iSQEqBUONZeab1IPA2c8gHOCpcyThObFAzM+Vvhcveicr+7bqLGxThuS4sSEZK2rqbOuxV7RyvFXZxoylfEwgqr8tEI22fjduYmdWsiL+Plhqa45fx7+1uxNmQnD/aFuHkr/bPF6pJM3uiJ1qGcl/8Vqtijxs0SRFpA+c9cDlRZNybCMqUivWu+8qbSFzWokn0Cl/g5QYzK+X+YYjPNfcTBbOEzlcLWp+zaYQx0GXiHYLUXay18xfgYRhAU0oYx5Dqqqbx8/q3ML8X5/XfW7c9sKg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XVjlCjEy+EoWz3nfyng/ViF7XeoVMhzycxJyUOxna6SXmECYZr4ly/GckZ8kUDOXShwItxfq4xJJqOkPfGgeRy8hdJg0cPKjhEnI7oObu8+xtAzlmUf8eutur2UJ8jwFkU45Jd6/6wS2pvD2tE7S3fIXaE5uK5d7QgYOa0XUCkzhEQ3C2dzWmfg39xM2/e8a+i/gANoDMsF+REI4j7TPjQlY7B/DvUYfqf5QyWa841BjcTI6zQ/9MQpK1L7ZjUbp0a/8vRTFFc712Gs4Ag8qC5HznFdm9pjIpJrJ61ecj2Kl37dVJaC3bmNfWC3rrCRFXI89rk/6g8AWgD1yvu5ToQ==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: AndrewCooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 17 Jul 2019 09:07:50 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVMZ+l48br4ffcsk28PZ/9fMg8ZKbNaATWgAEy1wA=
  • Thread-topic: [PATCH v2 4/5] x86: allow limiting the max C-state sub-state

On 16.07.2019 16:48, Roger Pau Monné  wrote:
> On Wed, Jul 03, 2019 at 01:03:02PM +0000, Jan Beulich wrote:
>> @@ -592,7 +608,13 @@ static void acpi_processor_idle(void)
>>    
>>            do {
>>                cx = &power->states[next_state];
>> -        } while ( cx->type > max_state && --next_state );
>> +        } while ( (cx->type > max_state ||
>> +                   cx->entry_method == ACPI_CSTATE_EM_NONE ||
>> +                   (cx->entry_method == ACPI_CSTATE_EM_FFH &&
>> +                    cx->type == max_cstate &&
>> +                    (cx->address & MWAIT_SUBSTATE_MASK) > max_csubstate)) &&
>> +                  --next_state );
>> +            cx = &power->states[next_state];
> 
> Is the line above a stray addition? It is at least not properly
> aligned AFAICT.

Oh, yes, that's a re-basing mistake. Thanks for spotting.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.