[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/2] x86/traps: guard top-of-stack reads



On 02.07.2019 19:47, Andrew Cooper wrote:
> On 17/06/2019 09:12, Jan Beulich wrote:
>> Nothing (afaics) guarantees that the original frame's stack pointer
> 
> I'd drop the (afaics), because the answer really is nothing.

Well, okay, done.

>> points at readable memory. Avoid a (likely nested) crash by attaching
>> exception recovery to the read (making it a single read at the same
>> time). Don't even invoke _show_trace() in case of a non-readable top
>> slot.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks. FTR - there's a quirk in here that I've left in place
deliberately (should probably have mentioned it in a post-commit-
message remark) which gets resolved by patch 2, and hence I'm
likely going to wait with committing this such that both can go in
at the same time. The issue is with the if/else-if/else chain here,
which patch 2 makes into a series of plain if()-s. Handling this
correctly right here would imo mean folding together both patches;
anything else would at best result in clumsy intermediate code.
Despite this quirk the change here is an improvement, just not as
much of one as would be desirable.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.