[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH V3 4/9] blk-zoned: update blkdev_reset_zones() with helper
- To: Minwoo Im <minwoo.im.dev@xxxxxxxxx>
- From: Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>
- Date: Wed, 3 Jul 2019 02:29:33 +0000
- Accept-language: en-US
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Chaitanya.Kulkarni@xxxxxxx;
- Cc: Damien Le Moal <Damien.LeMoal@xxxxxxx>, "linux-btrace@xxxxxxxxxxxxxxx" <linux-btrace@xxxxxxxxxxxxxxx>, "bvanassche@xxxxxxx" <bvanassche@xxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "yuchao0@xxxxxxxxxx" <yuchao0@xxxxxxxxxx>, "colyli@xxxxxxx" <colyli@xxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "linux-bcache@xxxxxxxxxxxxxxx" <linux-bcache@xxxxxxxxxxxxxxx>, "jaegeuk@xxxxxxxxxx" <jaegeuk@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "kent.overstreet@xxxxxxxxx" <kent.overstreet@xxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 03 Jul 2019 02:29:44 +0000
- Ironport-sdr: RHGJlDbjhGP2ZJcmx+kmVw2eYFmSmXpU6yt5ANml9SA6c3w206y3QQ3qscbRBjpW2D5raJhg6z Zu45ggnS24zkMK1d9NvCmJjMka5NeY/6E/5aT9LqR3z+XOMFWqWsSw6VzaOn8ZF6bt/C0rxrts c9E+sZRBlWZkEIdaLda6CdvO1YGPcGBrjqaMy5U3HXmVIGKI0x7/E2iSTAh+GTVNMXMEvNMDqM zpu6Q6BdIQwRLN0EHp7Onc4SwxumKIVB9Cka//O3ZyVzdiaSbZg1kcl8goKSIIGwHotYI8Z4ib im4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVMP2kFSOCc0lMzky+P079uDsX6Q==
- Thread-topic: [PATCH V3 4/9] blk-zoned: update blkdev_reset_zones() with helper
- Wdcipoutbound: EOP-TRUE
On 7/2/19 5:23 PM, Minwoo Im wrote:
> On 19-07-02 10:42:30, Chaitanya Kulkarni wrote:
>> This patch updates the blkdev_reset_zones() with newly introduced
>> helper function to read the nr_sects from block device's hd_parts with
>> the help of part_nr_sects_read().
> Chaitanya,
>
> Are the first three patches split for a special reason? IMHO, it could
> be squashed into a single one.
>
> It looks good to me, by the way.
In the blk-zoned.c in this way it is easier to bisect if/when the problem
comes.
>
> Reviewed-by: Minwoo Im <minwoo.im.dev@xxxxxxxxx>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
