Re: [Xen-devel] [PATCH v1] Use XEN_SCRIPT_DIR to refer to /etc/xen/scripts

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

Hi,

On Fri, Jun 21, 2019 at 11:29:44AM +0200, Olaf Hering wrote:
> Now that scripts are stored in libexec, replace all hardcoded paths to
> use XEN_SCRIPT_DIR to expand the actual location.

As far as I can tell, this isn't true, scripts are located in /etc.

If you want to move the scripts from /etc to libexec, it might be worth
doing so in a separated patch. And keep this patch to only move hard
codded strings "/etc/xen/scripts" to use XEN_SCRIPT_DIR instead.

Since this patch doesn't actually move anything, there might be a
different patch. The patch comment doesn't needs to discuss about it at
all. So removing the comment about location of scripts and the extra
hunk and this patch would be fine by me.

> Update .gitignore.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> ---
> diff --git a/docs/misc/block-scripts.txt b/docs/misc/block-scripts.txt
> index eabab100a8..8020787a52 100644
> --- a/docs/misc/block-scripts.txt
> +++ b/docs/misc/block-scripts.txt
> @@ -18,7 +18,7 @@ Setup
>  
>  It is highly recommended that custom hotplug scripts as much as
>  possible include and use the common Xen functionality.  If the script
> -is run from the normal block script location (/etc/xen/scripts by
> +is run from the normal block script location (/usr/lib/xen/scripts by

I don't think this hunk belong to this patch, it would be better to have
that in a different patch, I think.

>  default), then this can be done by adding the following to the top of
>  the script:
>  

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel