Re: [Xen-devel] [PATCH] xstate: make use_xsave non-init

[Jan Beulich <JBeulich@xxxxxxxx>]

On 01.07.2019 12:49, Roger Pau Monne wrote:
> --- a/xen/arch/x86/xstate.c
> +++ b/xen/arch/x86/xstate.c
> @@ -577,7 +577,7 @@ unsigned int xstate_ctxt_size(u64 xcr0)
>   /* Collect the information of processor's extended state */
>   void xstate_init(struct cpuinfo_x86 *c)
>   {
> -    static bool __initdata use_xsave = true;
> +    static bool use_xsave = true;

Please attach at least a brief comment here, such that people
won't consider the __initdata missing.

Of course I'd actually prefer the annotation to stay here in
the gcc case. Iirc there was one other case where there was
such an issue; I don't recall whether there it too got dealt
with by removing an annotation. How about we introduce an
annotation that expands to nothing in the clang case, but
continues to provide the same functionality for gcc? That
would then also clarify the reason for it being in any
particular place (I guess there are going to be more) without
the need for further commentary.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel